chrome/browser/ui/views/toolbar/home_button.cc - Issue 135633002: Don't populate URL data in WebDropData when dragging files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/home_button.cc

Issue 135633002: Don't populate URL data in WebDropData when dragging files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Blink style enums Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/home_button.cc

diff --git a/chrome/browser/ui/views/toolbar/home_button.cc b/chrome/browser/ui/views/toolbar/home_button.cc

index f20aada364d10ffb592cbc667c8127a6e1c0c088..74ffda6a5a760a3ce909e7872e0795bd4f9a89e2 100644

--- a/chrome/browser/ui/views/toolbar/home_button.cc

+++ b/chrome/browser/ui/views/toolbar/home_button.cc

@@ -165,7 +165,8 @@ int HomeButton::OnDragUpdated(const ui::DropTargetEvent& event) {

int HomeButton::OnPerformDrop(const ui::DropTargetEvent& event) {

GURL new_homepage_url;

base::string16 title;

- if (event.data().GetURLAndTitle(&new_homepage_url, &title) &&

+ if (event.data().GetURLAndTitle(

+ ui::OSExchangeData::CONVERT_FILENAMES, &new_homepage_url, &title) &&

new_homepage_url.is_valid()) {

PrefService* prefs = browser_->profile()->GetPrefs();

bool old_is_ntp = prefs->GetBoolean(prefs::kHomePageIsNewTabPage);