Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: docs/how_to_contribute.md

Issue 1356253003: [Docs] Add wiki content to Markdown docs (Closed) Base URL: https://chromium.googlesource.com/linux-syscall-support.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « docs/OWNERS ('k') | docs/projects_using_lss.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/how_to_contribute.md
diff --git a/docs/how_to_contribute.md b/docs/how_to_contribute.md
new file mode 100644
index 0000000000000000000000000000000000000000..df21fd52e9e4c22201e869bbaa35be9d2755c6fc
--- /dev/null
+++ b/docs/how_to_contribute.md
@@ -0,0 +1,26 @@
+# How to get an LSS change committed
+
+## Review
+
+You get your change reviewed, you can upload it to
+http://codereview.chromium.org (Rietveld) using `git cl upload` from Chromium's
+`depot-tools`.
+
+## Testing
+
+Unfortunately, LSS has no automated test suite.
+
+You can test LSS by patching it into Chromium, building Chromium, and running
+Chromium's tests. (See ProjectsUsingLSS.)
+
+You can compile-test LSS by running: `gcc -Wall -Wextra -Wstrict-prototypes -c
+linux_syscall_support.h
vapier 2015/09/22 16:30:14 do the _ need escaping ?
Bons 2015/09/22 16:35:10 No, not when it's within a code block.
+`
vapier 2015/09/22 16:30:14 should this be cuddled to the previous line ?
Bons 2015/09/22 16:35:10 Moved it to four-space indent.
+
+## Rolling into Chromium
+
+If you commit a change to LSS, please also commit a Chromium change to update
+`lss_revision` in Chromium's DEPS file.
+
+This ensures that the LSS change gets tested, so that people who commit later
+LSS changes don't run into problems with updating `lss_revision`.
« no previous file with comments | « docs/OWNERS ('k') | docs/projects_using_lss.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698