Chromium Code Reviews

Side by Side Diff: docs/how_to_contribute.md

Issue 1356253003: [Docs] Add wiki content to Markdown docs (Closed) Base URL: https://chromium.googlesource.com/linux-syscall-support.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « docs/OWNERS ('k') | docs/projects_using_lss.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # How to get an LSS change committed
2
3 ## Review
4
5 You get your change reviewed, you can upload it to
6 http://codereview.chromium.org (Rietveld) using `git cl upload` from Chromium's
7 `depot-tools`.
8
9 ## Testing
10
11 Unfortunately, LSS has no automated test suite.
12
13 You can test LSS by patching it into Chromium, building Chromium, and running
14 Chromium's tests. (See ProjectsUsingLSS.)
15
16 You can compile-test LSS by running: `gcc -Wall -Wextra -Wstrict-prototypes -c
17 linux_syscall_support.h
vapier 2015/09/22 16:30:14 do the _ need escaping ?
Bons 2015/09/22 16:35:10 No, not when it's within a code block.
18 `
vapier 2015/09/22 16:30:14 should this be cuddled to the previous line ?
Bons 2015/09/22 16:35:10 Moved it to four-space indent.
19
20 ## Rolling into Chromium
21
22 If you commit a change to LSS, please also commit a Chromium change to update
23 `lss_revision` in Chromium's DEPS file.
24
25 This ensures that the LSS change gets tested, so that people who commit later
26 LSS changes don't run into problems with updating `lss_revision`.
OLDNEW
« no previous file with comments | « docs/OWNERS ('k') | docs/projects_using_lss.md » ('j') | no next file with comments »

Powered by Google App Engine