Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 1356253003: [Docs] Add wiki content to Markdown docs (Closed)

Created:
5 years, 3 months ago by Bons
Modified:
5 years, 2 months ago
Reviewers:
Mark Seaborn, vapier
CC:
chromium-reviews, Markus (顧孟勤)
Base URL:
https://chromium.googlesource.com/linux-syscall-support.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A docs/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A docs/how_to_contribute.md View 1 1 chunk +26 lines, -0 lines 0 comments Download
A docs/projects_using_lss.md View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bons
5 years, 3 months ago (2015-09-22 15:34:03 UTC) #1
vapier
https://codereview.chromium.org/1356253003/diff/1/docs/how_to_contribute.md File docs/how_to_contribute.md (right): https://codereview.chromium.org/1356253003/diff/1/docs/how_to_contribute.md#newcode17 docs/how_to_contribute.md:17: linux_syscall_support.h do the _ need escaping ? https://codereview.chromium.org/1356253003/diff/1/docs/how_to_contribute.md#newcode18 docs/how_to_contribute.md:18: ...
5 years, 3 months ago (2015-09-22 16:30:14 UTC) #2
Bons
https://codereview.chromium.org/1356253003/diff/1/docs/how_to_contribute.md File docs/how_to_contribute.md (right): https://codereview.chromium.org/1356253003/diff/1/docs/how_to_contribute.md#newcode17 docs/how_to_contribute.md:17: linux_syscall_support.h On 2015/09/22 16:30:14, vapier wrote: > do the ...
5 years, 3 months ago (2015-09-22 16:35:11 UTC) #3
vapier
lgtm
5 years, 3 months ago (2015-09-22 16:36:15 UTC) #4
Bons
On 2015/09/22 16:36:15, vapier wrote: > lgtm You will have to land for me :)
5 years, 3 months ago (2015-09-22 16:36:54 UTC) #5
Bons
On 2015/09/22 16:36:54, Bons wrote: > On 2015/09/22 16:36:15, vapier wrote: > > lgtm > ...
5 years, 3 months ago (2015-09-24 14:49:15 UTC) #6
vapier
Committed patchset #2 (id:20001) manually as 7ed2476eea2c2a50fd40ec3e711dcb311d472753 (presubmit successful).
5 years, 3 months ago (2015-09-24 15:32:46 UTC) #7
vapier
sorry, missed your previous comment
5 years, 3 months ago (2015-09-24 15:33:08 UTC) #8
Mark Seaborn
On 2015/09/24 15:32:46, vapier wrote: > Committed patchset #2 (id:20001) manually as > 7ed2476eea2c2a50fd40ec3e711dcb311d472753 (presubmit ...
5 years, 2 months ago (2015-10-07 19:57:28 UTC) #9
vapier
5 years, 2 months ago (2015-10-07 21:03:34 UTC) #10
Message was sent while issue was closed.
sorry about that.  the two CLs coming in at the same time w/similar names
confused me and i thought there was only breakpad being posted.

i updated LSS (and merged the content here) into this CL:
https://codereview.chromium.org/1393083002/

and i reverted this one in breakpad here:
https://codereview.chromium.org/1395743002

Powered by Google App Engine
This is Rietveld 408576698