Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1356213003: [Android WebView] Put AndroidStreamReaderURLRequestJob into a namespace (Closed)

Created:
5 years, 3 months ago by mnaganov (inactive)
Modified:
5 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Put AndroidStreamReaderURLRequestJob into a namespace Put the class into android_webview ns, just like any other. Committed: https://crrev.com/2cd9d01be2194c4828307754c6f1334eb8bd7f57 Cr-Commit-Position: refs/heads/master@{#350055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M android_webview/browser/net/android_stream_reader_url_request_job.h View 3 chunks +6 lines, -5 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M android_webview/native/android_protocol_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
PTAL! Not sure how this managed to stay unnoticed through all these years :)
5 years, 3 months ago (2015-09-21 20:55:03 UTC) #2
boliu
lgtm
5 years, 3 months ago (2015-09-21 21:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356213003/1
5 years, 3 months ago (2015-09-21 22:38:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 22:54:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 22:55:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cd9d01be2194c4828307754c6f1334eb8bd7f57
Cr-Commit-Position: refs/heads/master@{#350055}

Powered by Google App Engine
This is Rietveld 408576698