Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc

Issue 1356213003: [Android WebView] Put AndroidStreamReaderURLRequestJob into a namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
diff --git a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
index 651d01d1e924529026426ca53718a3ec3fe93dba..37416bafe6fb538637221b7731613d83ce63cbbb 100644
--- a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
+++ b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
@@ -22,8 +22,6 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using android_webview::InputStream;
-using android_webview::InputStreamReader;
using net::TestDelegate;
using net::TestJobInterceptor;
using net::TestNetworkDelegate;
@@ -45,6 +43,10 @@ using testing::WithArg;
using testing::WithArgs;
using testing::_;
+namespace android_webview {
+
+namespace {
+
// Some of the classes will DCHECK on a null InputStream (which is desirable).
// The workaround is to use this class. None of the methods need to be
// implemented as the mock InputStreamReader should never forward calls to the
@@ -179,6 +181,9 @@ class TestStreamReaderJob : public AndroidStreamReaderURLRequestJob {
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
};
+} // namespace
+
+
class AndroidStreamReaderURLRequestJobTest : public Test {
public:
AndroidStreamReaderURLRequestJobTest() {}
@@ -415,3 +420,5 @@ TEST_F(AndroidStreamReaderURLRequestJobTest, DeleteJobMidWayRead) {
req_->Cancel();
EXPECT_EQ(1, network_delegate_.completed_requests());
}
+
+} // namespace android_webview

Powered by Google App Engine
This is Rietveld 408576698