Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ui/message_center/views/notification_view.cc

Issue 13560002: Added padding below text in notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/message_center_constants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notification_view.cc
diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc
index 65e8aee9b08204c5c7e39777c84957c2608f1944..521b4ae192aefe136794fd55cf90752aa24499ea 100644
--- a/ui/message_center/views/notification_view.cc
+++ b/ui/message_center/views/notification_view.cc
@@ -33,7 +33,6 @@ const int kIconColumnWidth = message_center::kNotificationIconSize;
const int kLegacyIconSize = 40;
const int kTextLeftPadding = kIconColumnWidth +
message_center::kIconToTextPadding;
-const int kTextBottomPadding = 6;
dharcourt 2013/04/03 17:41:45 This wasn't being used.
const int kTextRightPadding = 23;
const int kItemTitleToMessagePadding = 3;
const int kButtonHeight = 38;
@@ -395,7 +394,7 @@ NotificationView::NotificationView(const Notification& notification,
message_view_->SetElideBehavior(views::Label::ELIDE_AT_END);
message_view_->SetEnabledColor(message_center::kRegularTextColor);
message_view_->SetBackgroundColor(kRegularTextBackgroundColor);
- message_view_->set_border(MakeBorder(0, 3));
+ message_view_->set_border(MakeBorder(0, 4));
top_view_->AddChildView(message_view_);
}
@@ -409,6 +408,11 @@ NotificationView::NotificationView(const Notification& notification,
top_view_->AddChildView(item_view);
}
+ // Add padding below the title/message/list text.
+ views::View* padding_view = new views::ImageView();
msw 2013/04/03 18:04:26 Adding a view for padding is rather heavy-weight.
dharcourt 2013/04/04 18:33:52 I was able to accomplish this using borders, which
msw 2013/04/04 18:44:49 Awesome, that's even better.
+ padding_view->set_border(MakeBorder(5, 0));
+ top_view_->AddChildView(padding_view);
+
// Create the notification icon view.
if (notification.type() == NOTIFICATION_TYPE_SIMPLE) {
views::ImageView* icon_view = new views::ImageView();
« no previous file with comments | « ui/message_center/message_center_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698