Added padding below text in notifications.

ui/message_center/views/notification_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/notification_view.h"
 
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "grit/ui_resources.h"
 #include "ui/base/accessibility/accessible_view_state.h"
@@ skipping 15 matching lines @@
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 
 namespace {
 
 // Dimensions.
 const int kIconColumnWidth = message_center::kNotificationIconSize;
 const int kLegacyIconSize = 40;
 const int kTextLeftPadding = kIconColumnWidth +
     message_center::kIconToTextPadding;
-const int kTextBottomPadding = 6;

[dharcourt, 2013/04/03 17:41:45]

This wasn't being used.

 const int kTextRightPadding = 23;
 const int kItemTitleToMessagePadding = 3;
 const int kButtonHeight = 38;
 const int kButtonHorizontalPadding = 16;
 const int kButtonVecticalPadding = 0;
 const int kButtonIconTopPadding = 11;
 const int kButtonIconToTitlePadding = 16;
 const int kButtonTitleTopPadding = 0;
 
 const size_t kTitleCharacterLimit = 100;
@@ skipping 341 matching lines @@
         MaybeTruncateText(notification.message(), kMessageCharacterLimit));
     message_view_->SetVisible(!is_expanded() || !notification.items().size());
     message_view_->set_collapse_when_hidden(true);
     message_view_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     if (is_expanded())
       message_view_->SetMultiLine(true);
     else
       message_view_->SetElideBehavior(views::Label::ELIDE_AT_END);
     message_view_->SetEnabledColor(message_center::kRegularTextColor);
     message_view_->SetBackgroundColor(kRegularTextBackgroundColor);
-    message_view_->set_border(MakeBorder(0, 3));
+    message_view_->set_border(MakeBorder(0, 4));
     top_view_->AddChildView(message_view_);
   }
 
   // Create the list item views (up to a maximum).
   std::vector<NotificationItem> items = notification.items();
   for (size_t i = 0; i < items.size() && i < kNotificationMaximumItems; ++i) {
     ItemView* item_view = new ItemView(items[i]);
     item_view->SetVisible(is_expanded());
     item_view->set_border(MakeBorder(0, 4));
     item_views_.push_back(item_view);
     top_view_->AddChildView(item_view);
   }
 
+  // Add padding below the title/message/list text.
+  views::View* padding_view = new views::ImageView();

[msw, 2013/04/03 18:04:26]

Adding a view for padding is rather heavy-weight. Instead, just adjust
GetPreferredSize and Layout to include the additional inset.

[dharcourt, 2013/04/04 18:33:52]

I was able to accomplish this using borders, which leaves GetPreferredSize() and
Layout() simple and unaware of these padding details.

[msw, 2013/04/04 18:44:49]

Awesome, that's even better.

+  padding_view->set_border(MakeBorder(5, 0));
+  top_view_->AddChildView(padding_view);
+
   // Create the notification icon view.
   if (notification.type() == NOTIFICATION_TYPE_SIMPLE) {
     views::ImageView* icon_view = new views::ImageView();
     icon_view->SetImage(notification.icon().AsImageSkia());
     icon_view->SetImageSize(gfx::Size(kLegacyIconSize, kLegacyIconSize));
     icon_view->SetHorizontalAlignment(views::ImageView::CENTER);
     icon_view->SetVerticalAlignment(views::ImageView::CENTER);
     icon_view->set_background(MakeBackground(kLegacyIconBackgroundColor));
     icon_view_ = icon_view;
   } else {
@@ skipping 120 matching lines @@
                                              size_t limit) {
   // Currently just truncate the text by the total number of characters.
   // TODO(mukai): add better assumption like number of lines.
   if (!is_expanded())
     return text;
 
   return ui::TruncateString(text, limit);
 }
 
 }  // namespace message_center