Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/webcrypto/algorithms/aes_cbc_unittest.cc

Issue 1355923002: [refactor] Misc post-NSS WebCrypto cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@util_split
Patch Set: remove dupe header Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/webcrypto/algorithms/aes_cbc.cc ('K') | « components/webcrypto/algorithms/aes_cbc.cc ('k') | components/webcrypto/algorithms/aes_ctr.cc » ('j') | components/webcrypto/algorithms/aes_ctr.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/webcrypto/algorithms/aes_cbc_unittest.cc
diff --git a/components/webcrypto/algorithms/aes_cbc_unittest.cc b/components/webcrypto/algorithms/aes_cbc_unittest.cc
index 657c4a4c4325ee5f6c9f1a74464c050f04cff1f3..078b62d480e715eeb96f07a8b68b4c7cacab32e4 100644
--- a/components/webcrypto/algorithms/aes_cbc_unittest.cc
+++ b/components/webcrypto/algorithms/aes_cbc_unittest.cc
@@ -394,7 +394,7 @@ TEST_F(WebCryptoAesCbcTest, ImportExportJwk) {
"A256CBC");
}
-// AES 192-bit is not allowed: http://crbug.com/381829
+// 192-bit AES is intentionally unsupported (http://crubg.com/533699)
davidben 2015/09/22 19:08:24 ditto
TEST_F(WebCryptoAesCbcTest, GenerateAesCbc192) {
blink::WebCryptoKey key;
Status status = GenerateSecretKey(CreateAesCbcKeyGenAlgorithm(192), true,
@@ -402,7 +402,7 @@ TEST_F(WebCryptoAesCbcTest, GenerateAesCbc192) {
ASSERT_EQ(Status::ErrorAes192BitUnsupported(), status);
}
-// AES 192-bit is not allowed: http://crbug.com/381829
+// 192-bit AES is intentionally unsupported (http://crubg.com/533699)
davidben 2015/09/22 19:08:24 ditto
TEST_F(WebCryptoAesCbcTest, UnwrapAesCbc192) {
std::vector<uint8_t> wrapping_key_data(16, 0);
std::vector<uint8_t> wrapped_key = HexStringToBytes(
« components/webcrypto/algorithms/aes_cbc.cc ('K') | « components/webcrypto/algorithms/aes_cbc.cc ('k') | components/webcrypto/algorithms/aes_ctr.cc » ('j') | components/webcrypto/algorithms/aes_ctr.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698