Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: components/webcrypto/algorithms/aes.cc

Issue 1355923002: [refactor] Misc post-NSS WebCrypto cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@util_split
Patch Set: remove dupe header Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/webcrypto/algorithms/aes.cc
diff --git a/components/webcrypto/algorithms/aes.cc b/components/webcrypto/algorithms/aes.cc
index ed5bbb62a0f07cb1be6f5989b1c9978091ed184c..5c36a7d49002c95a9db790002064afd8eb5fd39a 100644
--- a/components/webcrypto/algorithms/aes.cc
+++ b/components/webcrypto/algorithms/aes.cc
@@ -56,7 +56,7 @@ Status AesAlgorithm::GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
unsigned int keylen_bits = algorithm.aesKeyGenParams()->lengthBits();
- // BoringSSL does not support 192-bit AES.
+ // 192-bit AES is intentionally unsupported (http://crubg.com/533699)
davidben 2015/09/22 19:08:24 Nit: period at end. Also crubg -> crbug (Ditto be
eroman 2015/09/22 22:25:38 Done (everywhere)
if (keylen_bits == 192)
return Status::ErrorAes192BitUnsupported();
@@ -87,7 +87,7 @@ Status AesAlgorithm::ImportKeyRaw(const CryptoData& key_data,
blink::WebCryptoKey* key) const {
const unsigned int keylen_bytes = key_data.byte_length();
- // BoringSSL does not support 192-bit AES.
+ // 192-bit AES is intentionally unsupported (http://crubg.com/533699)
if (keylen_bytes == 24)
return Status::ErrorAes192BitUnsupported();
@@ -178,7 +178,7 @@ Status AesAlgorithm::GetKeyLength(
if (*length_bits == 128 || *length_bits == 256)
return Status::Success();
- // BoringSSL does not support 192-bit AES.
+ // 192-bit AES is intentionally unsupported (http://crubg.com/533699)
if (*length_bits == 192)
return Status::ErrorAes192BitUnsupported();
« no previous file with comments | « no previous file | components/webcrypto/algorithms/aes_cbc.cc » ('j') | components/webcrypto/algorithms/aes_cbc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698