Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1355893002: Parametrize a variety of constants in preparation for changing them in MD. (Closed)

Created:
5 years, 3 months ago by Peter Kasting
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parametrize a variety of constants in preparation for changing them in MD. Right now these constants are all set to their existing values in all modes, so there should be no behavior change. This will allow me to easily change their values in the material design modes without having that change need to include the boilerplate of parametrizing them. (I already know from local work that I'll need to change all these.) This also cleans up the existing code in a few places. BUG=505805 TEST=none Committed: https://crrev.com/ba6a4101ba5ec284d79e9b3254addbd80e4ac48d Cr-Commit-Position: refs/heads/master@{#349829}

Patch Set 1 #

Patch Set 2 : Rebase + fix bugs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -85 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.h View 1 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/layout_constants.cc View 1 4 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 9 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -3 lines 1 comment Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 17 chunks +31 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
https://codereview.chromium.org/1355893002/diff/20001/chrome/browser/ui/views/tabs/tab_strip.h File chrome/browser/ui/views/tabs/tab_strip.h (left): https://codereview.chromium.org/1355893002/diff/20001/chrome/browser/ui/views/tabs/tab_strip.h#oldcode382 chrome/browser/ui/views/tabs/tab_strip.h:382: int GetTabOverlap() const; Turns out I didn't need this ...
5 years, 3 months ago (2015-09-18 20:40:46 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-09-18 20:51:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355893002/20001
5 years, 3 months ago (2015-09-19 00:59:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-19 01:05:27 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 01:06:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba6a4101ba5ec284d79e9b3254addbd80e4ac48d
Cr-Commit-Position: refs/heads/master@{#349829}

Powered by Google App Engine
This is Rietveld 408576698