Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: chrome/browser/ui/views/layout_constants.h

Issue 1355893002: Parametrize a variety of constants in preparation for changing them in MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + fix bugs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/layout_constants.h
diff --git a/chrome/browser/ui/views/layout_constants.h b/chrome/browser/ui/views/layout_constants.h
index a23bf0a47797d1e38d1a418d5c734c8beb8d1d6f..49032246741f19bab0676a78a0bea4d64a0cc551 100644
--- a/chrome/browser/ui/views/layout_constants.h
+++ b/chrome/browser/ui/views/layout_constants.h
@@ -37,6 +37,29 @@ enum LayoutConstant {
// The font size to use in the location bar and omnibox dropdown, in pixels.
OMNIBOX_FONT_PIXEL_SIZE,
+ // The amount of overlap between two adjacent tabs.
+ TABSTRIP_TAB_OVERLAP,
+
+ // The vertical overlap of the tabstrip atop the toolbar.
+ TABSTRIP_TOOLBAR_OVERLAP,
+
+ // The height of the shadow region above the top of the tabs.
+ TABSTRIP_TOP_SHADOW_HEIGHT,
+
+ // The amount by which the tab close button should overlap the trailing
+ // padding region after the tab's contents region.
+ TAB_CLOSE_BUTTON_TRAILING_PADDING_OVERLAP,
+
+ // The horizontal space between a tab's favicon and its title.
+ TAB_FAVICON_TITLE_SPACING,
+
+ // The maximum width we'll allow for a tab's title, when the tabstrip is wide
+ // enough for tabs to take as much space as they want.
+ TAB_MAXIMUM_TITLE_WIDTH,
+
+ // Width available for content inside a pinned tab.
+ TAB_PINNED_CONTENT_WIDTH,
+
// Non-ash uses a rounded content area with no shadow in the assets.
// Ash doesn't use a rounded content area and its top edge has an extra
// shadow.
@@ -62,6 +85,9 @@ enum LayoutInset {
// row edge.
OMNIBOX_DROPDOWN_TEXT,
+ // The padding inside the tab bounds that defines the tab contents region.
+ TAB,
+
// The spacing between a ToolbarButton's image and its border.
TOOLBAR_BUTTON,

Powered by Google App Engine
This is Rietveld 408576698