Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 135573002: Rename getType() to type() in ArrayBufferView (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
tkent, haraken, eseidel
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, yurys+blink_chromium.org, abarth-chromium, aandrey+blink_chromium.org, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, loislo+blink_chromium.org, Nate Chapin
Visibility:
Public.

Description

Rename getType() to type() in ArrayBufferView Rename getType() to type() in ArrayBufferView to follow Blink coding style. R=eseidel, tkent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165033

Patch Set 1 #

Patch Set 2 : Missed a few #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
Source/bindings/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/canvas/DataView.h View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/canvas/WebGLRenderingContext.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
Source/modules/crypto/Crypto.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/ArrayBufferView.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/ArrayBufferView.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Float32Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Float64Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Int16Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Int32Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Int8Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Uint16Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Uint32Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Uint8Array.h View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/Uint8ClampedArray.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 16:43:16 UTC) #1
haraken
LGTM
6 years, 11 months ago (2014-01-11 16:48:53 UTC) #2
Inactive
On 2014/01/11 16:48:53, haraken wrote: > LGTM Thanks. Still needs an lgtm from a wtf ...
6 years, 11 months ago (2014-01-13 21:03:42 UTC) #3
tkent
lgtm
6 years, 11 months ago (2014-01-14 00:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135573002/40001
6 years, 11 months ago (2014-01-14 00:38:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135573002/40001
6 years, 11 months ago (2014-01-14 06:09:29 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 06:46:36 UTC) #7
Message was sent while issue was closed.
Change committed as 165033

Powered by Google App Engine
This is Rietveld 408576698