Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1355673004: MSE: Maintain continuity in sequence appendMode across ResetParserState (Closed)

Created:
5 years, 3 months ago by wolenetz
Modified:
5 years, 3 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Maintain continuity in sequence appendMode across ResetParserState This change fixes Chromium to match the expected fix for MSE spec bug 29133 (which has a pull request with the associated spec language update pending review at https://github.com/w3c/media-source/pull/9). BUG=533113 TEST=FrameProcessorTest.AudioOnly_SequenceModeContinuityAcrossReset R=chcunningham@chromium.org Committed: https://crrev.com/eb774ca399d680db7885a01ce5cf48eb1260f57b Cr-Commit-Position: refs/heads/master@{#349581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M media/filters/frame_processor.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
wolenetz
Please take a look. Thanks!
5 years, 3 months ago (2015-09-17 22:40:45 UTC) #1
wolenetz
On 2015/09/17 22:40:45, wolenetz wrote: > Please take a look. > Thanks! Note, as expected, ...
5 years, 3 months ago (2015-09-17 22:48:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355673004/1
5 years, 3 months ago (2015-09-17 22:50:49 UTC) #4
chcunningham
lgtm
5 years, 3 months ago (2015-09-18 00:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355673004/1
5 years, 3 months ago (2015-09-18 00:11:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 01:46:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 01:46:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb774ca399d680db7885a01ce5cf48eb1260f57b
Cr-Commit-Position: refs/heads/master@{#349581}

Powered by Google App Engine
This is Rietveld 408576698