content/gpu: Remove separate queue for out-of-order messages.

content/gpu: Remove separate queue for out-of-order messages.

This CL gets rid of the separate deque for out of order messages and the
complexity associated with that in GpuChannel::HandleMessage.

BUG=514813
Committed: https://crrev.com/5ccdf4577097476e078ae36cce8d4e2107df86f6
Cr-Commit-Position: refs/heads/master@{#349872}

[sunnyps, 2015-09-18 01:32:28]

sunnyps@chromium.org changed reviewers:
+ dyen@chromium.org, piman@chromium.org

[sunnyps, 2015-09-18 01:32:29]

PTAL

[piman, 2015-09-18 03:44:15]

LGTM+nits

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
File content/common/gpu/gpu_channel.cc (right):

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
content/common/gpu/gpu_channel.cc:280: DCHECK(!message.should_unblock() &&
!message.is_reply());
nit: it's not really a valid DCHECK, a compromised renderer can send one of this
type of message. We shouldn't make the assumption that they can't happen.

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
content/common/gpu/gpu_channel.cc:888:
(uint32_t)GpuCommandBufferMsg_WaitForGetOffsetInRange::ID) ||
nit: no c-style cast

[David Yen, 2015-09-18 18:02:18]

lgtm

[sunnyps, 2015-09-18 18:47:29]

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
File content/common/gpu/gpu_channel.cc (right):

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
content/common/gpu/gpu_channel.cc:280: DCHECK(!message.should_unblock() &&
!message.is_reply());
On 2015/09/18 03:44:15, piman (slow to review) wrote:
> nit: it's not really a valid DCHECK, a compromised renderer can send one of
this
> type of message. We shouldn't make the assumption that they can't happen.

Done.

https://codereview.chromium.org/1355643003/diff/1/content/common/gpu/gpu_chan...
content/common/gpu/gpu_channel.cc:888:
(uint32_t)GpuCommandBufferMsg_WaitForGetOffsetInRange::ID) ||
On 2015/09/18 03:44:15, piman (slow to review) wrote:
> nit: no c-style cast

Replaced this with a switch statement which doesn't need a cast.

[piman, 2015-09-18 20:03:40]

LGTM + nits

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
File content/common/gpu/gpu_channel.cc (right):

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
content/common/gpu/gpu_channel.cc:282: LOG(ERROR) << "Unexpected message type";
nit: DLOG/DVLOG. No need to include the string and the logging code in release.

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
content/common/gpu/gpu_channel.cc:295: LOG(ERROR) << "Untrusted client should
not send "
same here.

[sunnyps, 2015-09-18 21:02:08]

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
File content/common/gpu/gpu_channel.cc (right):

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
content/common/gpu/gpu_channel.cc:282: LOG(ERROR) << "Unexpected message type";
On 2015/09/18 20:03:40, piman (slow to review) wrote:
> nit: DLOG/DVLOG. No need to include the string and the logging code in
release.

Done.

https://codereview.chromium.org/1355643003/diff/20001/content/common/gpu/gpu_...
content/common/gpu/gpu_channel.cc:295: LOG(ERROR) << "Untrusted client should
not send "
On 2015/09/18 20:03:40, piman (slow to review) wrote:
> same here.

Done.

[piman, 2015-09-18 21:08:50]

lgtm

[sunnyps, 2015-09-19 19:11:19]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-09-19 19:11:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dyen@chromium.org
Link to the patchset: https://codereview.chromium.org/1355643003/#ps40001
(title: "DLOG")

[commit-bot: I haz the power, 2015-09-19 19:11:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1355643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1355643003/40001

[commit-bot: I haz the power, 2015-09-19 21:40:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-19 21:40:58]

Patchset 3 (id:??) landed as
https://crrev.com/5ccdf4577097476e078ae36cce8d4e2107df86f6
Cr-Commit-Position: refs/heads/master@{#349872}