Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1348363003: content/gpu: Simplify stub scheduling. (Closed)

Created:
5 years, 3 months ago by sunnyps
Modified:
5 years, 3 months ago
Reviewers:
sky, jbauman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gpu_channel_stream
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/gpu: Simplify stub scheduling. Get rid of the reschedule timeout in GpuScheduler. Also let the channel know which stub is scheduled/descheduled so that it can map it to the correct stream. BUG=514813 Committed: https://crrev.com/baab86ff3d07870373266e101b0cf8916d4af188 Cr-Commit-Position: refs/heads/master@{#349788}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Total comments: 4

Patch Set 3 : piman's review #

Total comments: 2

Patch Set 4 : piman's review #

Patch Set 5 : fix compile errors #

Patch Set 6 : rebase #

Patch Set 7 : fix android compile error #

Patch Set 8 : fix android compile error sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -131 lines) Patch
M components/mus/gles2/command_buffer_driver.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel.h View 1 2 3 4 5 1 chunk +1 line, -7 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 3 4 5 7 chunks +23 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 2 3 4 5 4 chunks +5 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 2 3 4 5 7 chunks +13 lines, -79 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 30 (10 generated)
sunnyps
PTAL I've let the refcounting for schedule/unschedule remain but it's not being used so I ...
5 years, 3 months ago (2015-09-16 21:24:17 UTC) #2
jbauman
lgtm, with one suggestion https://codereview.chromium.org/1348363003/diff/1/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): https://codereview.chromium.org/1348363003/diff/1/content/common/gpu/gpu_command_buffer_stub.cc#newcode919 content/common/gpu/gpu_command_buffer_stub.cc:919: scheduler_->SetScheduled(false); DCHECK(!waiting_for_sync_point_);
5 years, 3 months ago (2015-09-16 21:31:26 UTC) #3
piman
I'm ok if we remove refcounting of unschedules, if we replace it by a DCHECK. ...
5 years, 3 months ago (2015-09-16 21:46:29 UTC) #4
sunnyps
PTAL https://codereview.chromium.org/1348363003/diff/1/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): https://codereview.chromium.org/1348363003/diff/1/content/common/gpu/gpu_command_buffer_stub.cc#newcode919 content/common/gpu/gpu_command_buffer_stub.cc:919: scheduler_->SetScheduled(false); On 2015/09/16 21:31:26, jbauman wrote: > DCHECK(!waiting_for_sync_point_); ...
5 years, 3 months ago (2015-09-16 23:08:32 UTC) #5
jbauman
On 2015/09/16 23:08:32, sunnyps wrote: > PTAL > > https://codereview.chromium.org/1348363003/diff/1/content/common/gpu/gpu_command_buffer_stub.cc > File content/common/gpu/gpu_command_buffer_stub.cc (right): > ...
5 years, 3 months ago (2015-09-16 23:18:06 UTC) #6
piman
https://codereview.chromium.org/1348363003/diff/20001/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): https://codereview.chromium.org/1348363003/diff/20001/content/common/gpu/gpu_command_buffer_stub.cc#newcode927 content/common/gpu/gpu_command_buffer_stub.cc:927: return waiting_for_sync_point_; return !waiting_for_sync_point_;
5 years, 3 months ago (2015-09-16 23:21:09 UTC) #7
sunnyps
PTAL Removed the refcounting for SetScheduled as well. https://codereview.chromium.org/1348363003/diff/20001/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): https://codereview.chromium.org/1348363003/diff/20001/content/common/gpu/gpu_command_buffer_stub.cc#newcode927 content/common/gpu/gpu_command_buffer_stub.cc:927: return ...
5 years, 3 months ago (2015-09-16 23:38:42 UTC) #8
piman
https://codereview.chromium.org/1348363003/diff/20001/gpu/command_buffer/service/gpu_scheduler.cc File gpu/command_buffer/service/gpu_scheduler.cc (right): https://codereview.chromium.org/1348363003/diff/20001/gpu/command_buffer/service/gpu_scheduler.cc#newcode32 gpu/command_buffer/service/gpu_scheduler.cc:32: unscheduled_count_(0), You still need an initializer for scheduled_. https://codereview.chromium.org/1348363003/diff/40001/gpu/command_buffer/service/gpu_scheduler.cc ...
5 years, 3 months ago (2015-09-16 23:48:43 UTC) #9
sunnyps
PTAL https://codereview.chromium.org/1348363003/diff/20001/gpu/command_buffer/service/gpu_scheduler.cc File gpu/command_buffer/service/gpu_scheduler.cc (right): https://codereview.chromium.org/1348363003/diff/20001/gpu/command_buffer/service/gpu_scheduler.cc#newcode32 gpu/command_buffer/service/gpu_scheduler.cc:32: unscheduled_count_(0), On 2015/09/16 23:48:42, piman (slow to review) ...
5 years, 3 months ago (2015-09-17 00:04:53 UTC) #10
piman
lgtm
5 years, 3 months ago (2015-09-17 00:13:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348363003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348363003/100001
5 years, 3 months ago (2015-09-18 17:48:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/134484)
5 years, 3 months ago (2015-09-18 18:14:33 UTC) #16
sunnyps
+sky for mus/components/gles2 rubber stamp
5 years, 3 months ago (2015-09-18 18:20:16 UTC) #17
sunnyps
actually +sky
5 years, 3 months ago (2015-09-18 18:20:37 UTC) #19
sky
LGTM
5 years, 3 months ago (2015-09-18 20:15:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348363003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348363003/120001
5 years, 3 months ago (2015-09-18 20:23:03 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/134560)
5 years, 3 months ago (2015-09-18 20:41:38 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348363003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348363003/140001
5 years, 3 months ago (2015-09-18 20:49:20 UTC) #28
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 3 months ago (2015-09-18 22:34:17 UTC) #29
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 22:34:43 UTC) #30
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/baab86ff3d07870373266e101b0cf8916d4af188
Cr-Commit-Position: refs/heads/master@{#349788}

Powered by Google App Engine
This is Rietveld 408576698