Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4729)

Unified Diff: chrome/browser/ssl/bad_clock_blocking_page.cc

Issue 1355413003: Move error classification into the ssl_errors component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/bad_clock_blocking_page.cc
diff --git a/chrome/browser/ssl/bad_clock_blocking_page.cc b/chrome/browser/ssl/bad_clock_blocking_page.cc
index 2d89b105e6fc2f119465d7cec04f444c156c2b17..a12d90031abd106823f53472f3e4f299b3271fbf 100644
--- a/chrome/browser/ssl/bad_clock_blocking_page.cc
+++ b/chrome/browser/ssl/bad_clock_blocking_page.cc
@@ -23,10 +23,11 @@
#include "chrome/browser/interstitials/chrome_metrics_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/renderer_preferences_util.h"
-#include "chrome/browser/ssl/ssl_error_classification.h"
+#include "chrome/browser/ssl/chrome_error_classification.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "components/google/core/browser/google_util.h"
+#include "components/ssl_errors/error_classification.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/cert_store.h"
#include "content/public/browser/interstitial_page.h"
@@ -189,9 +190,9 @@ BadClockBlockingPage::BadClockBlockingPage(
security_interstitials::MetricsHelper::TOTAL_VISITS);
// TODO(felt): Separate the clock statistics from the main ssl statistics.
- scoped_ptr<SSLErrorClassification> classifier(
- new SSLErrorClassification(web_contents, time_triggered_, request_url,
- cert_error_, *ssl_info_.cert.get()));
+ scoped_ptr<ChromeErrorClassification> classifier(
+ new ChromeErrorClassification(web_contents, time_triggered_, request_url,
estark 2015/09/23 22:42:19 I think this can just be a ErrorClassification (do
+ cert_error_, *ssl_info_.cert.get()));
classifier->RecordUMAStatistics(false);
}
@@ -235,7 +236,7 @@ void BadClockBlockingPage::PopulateInterstitialStrings(
#endif
int heading_string =
- SSLErrorClassification::IsUserClockInTheFuture(time_triggered_)
+ ssl_errors::ErrorClassification::IsUserClockInTheFuture(time_triggered_)
? IDS_CLOCK_ERROR_AHEAD_HEADING
: IDS_CLOCK_ERROR_BEHIND_HEADING;
« no previous file with comments | « no previous file | chrome/browser/ssl/chrome_error_classification.h » ('j') | chrome/browser/ssl/ssl_blocking_page.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698