Move error classification into the ssl_errors component

chrome/browser/ssl/bad_clock_blocking_page.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/bad_clock_blocking_page.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/build_time.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/time_formatting.h"
 #include "base/process/launch.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/interstitials/chrome_metrics_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
-#include "chrome/browser/ssl/ssl_error_classification.h"
+#include "chrome/browser/ssl/chrome_error_classification.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/google/core/browser/google_util.h"
+#include "components/ssl_errors/error_classification.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/signed_certificate_timestamp_store.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 142 matching lines @@
       ssl_info_(ssl_info),
       time_triggered_(time_triggered) {
   security_interstitials::MetricsHelper::ReportDetails reporting_info;
   reporting_info.metric_prefix = kMetricsName;
   set_metrics_helper(new ChromeMetricsHelper(web_contents, request_url,
                                              reporting_info, kMetricsName));
   metrics_helper()->RecordUserInteraction(
       security_interstitials::MetricsHelper::TOTAL_VISITS);
 
   // TODO(felt): Separate the clock statistics from the main ssl statistics.
-  scoped_ptr<SSLErrorClassification> classifier(
-      new SSLErrorClassification(web_contents, time_triggered_, request_url,
-                                 cert_error_, *ssl_info_.cert.get()));
+  scoped_ptr<ChromeErrorClassification> classifier(
+      new ChromeErrorClassification(web_contents, time_triggered_, request_url,

[estark, 2015/09/23 22:42:19]

I think this can just be a ErrorClassification (doesn't need to be ChromeEC).

+                                    cert_error_, *ssl_info_.cert.get()));
   classifier->RecordUMAStatistics(false);
 }
 
 bool BadClockBlockingPage::ShouldCreateNewNavigation() const {
   return true;
 }
 
 InterstitialPageDelegate::TypeID BadClockBlockingPage::GetTypeForTesting()
     const {
   return BadClockBlockingPage::kTypeForTesting;
@@ skipping 23 matching lines @@
   // Strings for the bad clock warning specifically.
   load_time_data->SetBoolean("bad_clock", true);
   load_time_data->SetBoolean("overridable", false);
 #if defined(OS_IOS)
   load_time_data->SetBoolean("hide_primary_button", true);
 #else
   load_time_data->SetBoolean("hide_primary_button", false);
 #endif
 
   int heading_string =
-      SSLErrorClassification::IsUserClockInTheFuture(time_triggered_)
+      ssl_errors::ErrorClassification::IsUserClockInTheFuture(time_triggered_)
           ? IDS_CLOCK_ERROR_AHEAD_HEADING
           : IDS_CLOCK_ERROR_BEHIND_HEADING;
 
   load_time_data->SetString("tabTitle",
                             l10n_util::GetStringUTF16(IDS_CLOCK_ERROR_TITLE));
   load_time_data->SetString("heading",
                             l10n_util::GetStringUTF16(heading_string));
   load_time_data->SetString(
       "primaryParagraph",
       l10n_util::GetStringFUTF16(
@@ skipping 105 matching lines @@
 
 void BadClockBlockingPage::NotifyDenyCertificate() {
   // It's possible that callback_ may not exist if the user clicks "Proceed"
   // followed by pressing the back button before the interstitial is hidden.
   // In that case the certificate will still be treated as allowed.
   if (callback_.is_null())
     return;
 
   base::ResetAndReturn(&callback_).Run(false);
 }