Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355263002: Make sure <url>s are being serialized according to spec (Closed)

Created:
5 years, 3 months ago by nainar
Modified:
5 years, 3 months ago
Reviewers:
CC:
blink-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, rwlbuis, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@urlThing161644
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make sure <url>s are being serialized according to spec Chrome doesn't serialize string as is stated in the spec here: https://drafts.csswg.org/cssom/#serialize-a-string. Each string passed to a URL is supposed to be in quotes. As opposed to what we do currently. Gecko on Firefox does this right. BUG=534674

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -322 lines) Patch
M LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-multiple-layers.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-multiple-layers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html View 4 chunks +27 lines, -27 lines 0 comments Download
M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/fast/backgrounds/multiple-backgrounds-computed-style-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/background-position-serialize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/background-serialize.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/background-serialize-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/css-escaped-identifier.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/css-imagevalue-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/cursor-parsing.html View 1 2 chunks +19 lines, -19 lines 0 comments Download
M LayoutTests/fast/css/cursor-parsing-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/cursor-parsing-image-set.html View 1 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/css/cursor-parsing-image-set-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/cursor-parsing-quirks.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/cursor-parsing-quirks-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle-relativeURL.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html View 3 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt View 3 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade.html View 1 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-cross-fade-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-properties.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-properties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.html View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/image-set-parsing-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/image-set-setting-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/parse-border-image-repeat-null-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/script-tests/image-set-parsing.js View 1 1 chunk +22 lines, -12 lines 0 comments Download
M LayoutTests/fast/css/script-tests/image-set-setting.js View 1 1 chunk +12 lines, -6 lines 0 comments Download
M LayoutTests/fast/css/uri-token-parsing.html View 1 chunk +23 lines, -23 lines 0 comments Download
M LayoutTests/fast/css/uri-token-parsing-expected.txt View 1 chunk +46 lines, -46 lines 0 comments Download
M LayoutTests/fast/css/url-with-multi-byte-unicode-escape.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/url-with-multi-byte-unicode-escape-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/innerHTML/innerHTML-uri-resolution.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/inspector-support/cssURLQuotes.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/inspector-support/cssURLQuotes-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/resources/image-preload-helper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/masking/parsing-mask.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/masking/parsing-mask-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-outside.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-test-utils.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/resources/js-test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSMarkup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSMarkup.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1306283006 Patch 320001

Powered by Google App Engine
This is Rietveld 408576698