Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

Issue 1355263002: Make sure <url>s are being serialized according to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@urlThing161644
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
diff --git a/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html b/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
index 85e9df4d9e68557235fa0f52faeb3f1f80277c16..fc8a7622e6fadc96de6c2710521ff8de44ed53f2 100644
--- a/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
+++ b/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
@@ -22,74 +22,74 @@ function checkComputedStyleValue() {
return (window.getComputedStyle(e, null).getPropertyValue('background') == before);
}
-e.style.background = "center / cover red url(dummy://test.png) no-repeat border-box";
-shouldBe("e.style.background", "'url(dummy://test.png) 50% 50% / cover no-repeat border-box border-box red'");
+e.style.background = "center / cover red url(\"dummy://test.png\") no-repeat border-box";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 50% 50% / cover no-repeat border-box border-box red'");
shouldBe("e.style.backgroundSize", "'cover'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) no-repeat scroll 50% 50% / cover border-box border-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") no-repeat scroll 50% 50% / cover border-box border-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'cover'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "red 20px / contain url(dummy://test.png) no-repeat padding-box";
-shouldBe("e.style.background", "'url(dummy://test.png) 20px 50% / contain no-repeat padding-box padding-box red'");
+e.style.background = "red 20px / contain url(\"dummy://test.png\") no-repeat padding-box";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 20px 50% / contain no-repeat padding-box padding-box red'");
shouldBe("e.style.backgroundSize", "'contain'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) no-repeat scroll 20px 50% / contain padding-box padding-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") no-repeat scroll 20px 50% / contain padding-box padding-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'contain'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "red url(dummy://test.png) 50px 60px / 50% 75% no-repeat";
-shouldBe("e.style.background", "'url(dummy://test.png) 50px 60px / 50% 75% no-repeat red'");
+e.style.background = "red url(\"dummy://test.png\") 50px 60px / 50% 75% no-repeat";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 50px 60px / 50% 75% no-repeat red'");
shouldBe("e.style.backgroundSize", "'50% 75%'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) no-repeat scroll 50px 60px / 50% 75% padding-box border-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") no-repeat scroll 50px 60px / 50% 75% padding-box border-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'50% 75%'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "red url(dummy://test.png) repeat top left / 100px 200px border-box content-box";
-shouldBe("e.style.background", "'url(dummy://test.png) 0% 0% / 100px 200px repeat border-box content-box red'");
+e.style.background = "red url(\"dummy://test.png\") repeat top left / 100px 200px border-box content-box";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 0% 0% / 100px 200px repeat border-box content-box red'");
shouldBe("e.style.backgroundSize", "'100px 200px'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) repeat scroll 0% 0% / 100px 200px border-box content-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") repeat scroll 0% 0% / 100px 200px border-box content-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'100px 200px'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "red url(dummy://test.png) repeat 50% / auto auto content-box padding-box";
-shouldBe("e.style.background", "'url(dummy://test.png) 50% 50% / auto repeat content-box padding-box red'");
+e.style.background = "red url(\"dummy://test.png\") repeat 50% / auto auto content-box padding-box";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 50% 50% / auto repeat content-box padding-box red'");
shouldBe("e.style.backgroundSize", "'auto'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) repeat scroll 50% 50% / auto content-box padding-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") repeat scroll 50% 50% / auto content-box padding-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'auto'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "url(dummy://test.png) red 50px 60px / 50% no-repeat fixed";
-shouldBe("e.style.background", "'url(dummy://test.png) 50px 60px / 50% no-repeat fixed red'");
+e.style.background = "url(\"dummy://test.png\") red 50px 60px / 50% no-repeat fixed";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 50px 60px / 50% no-repeat fixed red'");
shouldBe("e.style.backgroundSize", "'50%'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) no-repeat fixed 50px 60px / 50% padding-box border-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") no-repeat fixed 50px 60px / 50% padding-box border-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'50%'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "red repeat scroll padding-box border-box top left / 100px url(dummy://test.png)";
-shouldBe("e.style.background", "'url(dummy://test.png) 0% 0% / 100px repeat scroll padding-box border-box red'");
+e.style.background = "red repeat scroll padding-box border-box top left / 100px url(\"dummy://test.png\")";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 0% 0% / 100px repeat scroll padding-box border-box red'");
shouldBe("e.style.backgroundSize", "'100px'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) repeat scroll 0% 0% / 100px padding-box border-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") repeat scroll 0% 0% / 100px padding-box border-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'100px'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
-e.style.background = "50% / auto fixed url(dummy://test.png) repeat content-box red";
-shouldBe("e.style.background", "'url(dummy://test.png) 50% 50% / auto repeat fixed content-box content-box red'");
+e.style.background = "50% / auto fixed url(\"dummy://test.png\") repeat content-box red";
+shouldBe("e.style.background", "'url(\"dummy://test.png\") 50% 50% / auto repeat fixed content-box content-box red'");
shouldBe("e.style.backgroundSize", "'auto'");
shouldBe("checkStyle()", "true");
-shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(dummy://test.png) repeat fixed 50% 50% / auto content-box content-box'");
+shouldBe('computedStyle.getPropertyValue("background")', "'rgb(255, 0, 0) url(\"dummy://test.png\") repeat fixed 50% 50% / auto content-box content-box'");
shouldBe('computedStyle.getPropertyValue("background-size")', "'auto'");
shouldBe("checkComputedStyleValue()", "true");
debug("")
@@ -113,7 +113,7 @@ shouldBe("checkComputedStyleValue()", "true");
debug("")
e.style.background = "";
-e.style.background = "red / cover url(dummy://test.png) repeat";
+e.style.background = "red / cover url(\"dummy://test.png\") repeat";
shouldBe("e.style.background", "''");
shouldBe("e.style.backgroundSize", "''");
shouldBe("checkStyle()", "true");
@@ -123,7 +123,7 @@ shouldBe("checkComputedStyleValue()", "true");
debug("")
e.style.background = "";
-e.style.background = "red url(dummy://test.png) repeat 25px / contain contain";
+e.style.background = "red url(\"dummy://test.png\") repeat 25px / contain contain";
shouldBe("e.style.background", "''");
shouldBe("e.style.backgroundSize", "''");
shouldBe("checkStyle()", "true");
@@ -133,7 +133,7 @@ shouldBe("checkComputedStyleValue()", "true");
debug("")
e.style.background = "";
-e.style.background = "red top left / 100px cover url(dummy://test.png) repeat";
+e.style.background = "red top left / 100px cover url(\"dummy://test.png\") repeat";
shouldBe("e.style.background", "''");
shouldBe("e.style.backgroundSize", "''");
shouldBe("checkStyle()", "true");

Powered by Google App Engine
This is Rietveld 408576698