Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355193002: Reland again [Telemetry] Refactor Chrome devtools tracing (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, yurys, yzshen+watch_chromium.org, devtools-reviews_chromium.org, pfeldman, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland again [Telemetry] Refactor Chrome devtools tracing This CL tries to reland https://crrev.com/1347563002/ with the fix. Platform-level tracing doc: https://docs.google.com/document/d/1Uv8SzOq2ugvzLiOcP85g7qPiaxwsn4tgOdxpe3YjUkM/edit?usp=sharing BUG=515323, 531755, 534233 Committed: https://crrev.com/88ad0ccc5de9d9ed34f23837b49084a5cf33c645 Cr-Commit-Position: refs/heads/master@{#350009}

Patch Set 1 : patch 1347563002 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -177 lines) Patch
M tools/telemetry/telemetry/internal/app/android_process.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py View 4 chunks +31 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py View 1 2 chunks +27 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome_inspector/websocket.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_devtools_tracing_backend.py View 1 chunk +0 lines, -114 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py View 3 chunks +45 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent_unittest.py View 8 chunks +50 lines, -42 lines 0 comments Download
A tools/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_devtools_manager.py View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhen Wang
5 years, 3 months ago (2015-09-21 19:21:33 UTC) #2
nednguyen
lgtm
5 years, 3 months ago (2015-09-21 19:40:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355193002/20001
5 years, 3 months ago (2015-09-21 19:41:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 20:28:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 20:29:33 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/88ad0ccc5de9d9ed34f23837b49084a5cf33c645
Cr-Commit-Position: refs/heads/master@{#350009}

Powered by Google App Engine
This is Rietveld 408576698