tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py - Issue 1355193002: Reland again [Telemetry] Refactor Chrome devtools tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 1355193002: Reland again [Telemetry] Refactor Chrome devtools tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/app/android_process.py ('k') | tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

index 2c99046fc4efd14a4cf01c05d525760096d84ddb..7fa3b9834c0dae25f910daf734b3e14080ba5c23 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

@@ -173,7 +173,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def HasBrowserFinishedLaunching(self):

assert self._port, 'No DevTools port info available.'

- return devtools_client_backend.IsDevToolsAgentAvailable(self._port)

+ return devtools_client_backend.IsDevToolsAgentAvailable(self._port, self)

def _InitDevtoolsClientBackend(self, remote_devtools_port=None):

""" Initiate the devtool client backend which allow browser connection