Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1355003002: Floats on clean lines that are dirtied during layout (Closed)

Created:
5 years, 3 months ago by rhogan
Modified:
5 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Floats on clean lines that are dirtied during layout This is a follow-up fix to https://codereview.chromium.org/1306733003 with some opportunistic refactoring to remove duplicate code. When tying floats to the (current) last line-box in block-flow we may hit a float in lines previously considered clean but which we have since decided to continue laying out past (e.g.because one of our floats has changed size). If that happens we need to add the floats to the linebox rather than bailing early. In https://codereview.chromium.org/1306733003 we weren't catering for the possibility that we may have given up on the plan to stop at clean lines. In the refactoring I got rid of a superfluous bool and refactored some common code into a function. Now, if we give up on staying within clean lines we immediately delete them rather than relying on layout state to figure out if we need to do it later. BUG=532712

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
A LayoutTests/fast/block/float/float-on-clean-line-subsequently-dirtied.html View 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/fast/block/float/float-on-clean-line-subsequently-dirtied-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 1 5 chunks +39 lines, -48 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
rhogan
5 years, 3 months ago (2015-09-22 20:43:02 UTC) #2
eae
LGTM
5 years, 3 months ago (2015-09-23 14:48:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355003002/20001
5 years, 3 months ago (2015-09-23 16:44:06 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 16:53:04 UTC) #7
Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698