Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1306733003: Don't add floats on clean lines to new lineboxes (Closed)

Created:
5 years, 4 months ago by rhogan
Modified:
5 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't add floats on clean lines to new lineboxes When tying floats in a block-flow to the last linebox stop when we hit a float that sits in clean lines in the block-flow. BUG=492918 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201680

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, --1 lines) Patch
A LayoutTests/fast/block/float/float-on-clean-line.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + LayoutTests/fast/block/float/float-on-clean-line-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
rhogan
5 years, 3 months ago (2015-09-02 19:45:19 UTC) #2
eae
Nice fix, thank you!
5 years, 3 months ago (2015-09-02 20:33:33 UTC) #3
eae
LGTM
5 years, 3 months ago (2015-09-02 20:36:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306733003/20001
5 years, 3 months ago (2015-09-02 22:10:39 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 23:15:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201680

Powered by Google App Engine
This is Rietveld 408576698