Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1354993003: H264 Decoder: move cut off logic from Construct to ModifyRefPicList(). (Closed)

Created:
5 years, 3 months ago by hshi1
Modified:
5 years, 3 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

H264 Decoder: move cut off logic from Construct to ModifyRefPicList(). The ConstructRefPicListsP/B() functions are supposed to be slice agnostic. The cut off logic is based on per-slice num_ref_idx_lX_active_minus1 values in the slice header, and therefore it should belong to the ModifyRefPicList() function. BUG=479953 TEST=verify no corruption on xfnity, trybot, vda unit test Review URL: https://codereview.chromium.org/1318283007 Cr-Commit-Position: refs/heads/master@{#346947} (cherry picked from commit 5e19b061b92dd718401660d1899fd56bcd8637f9) TBR=posciak@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1323143006 Cr-Commit-Position: refs/branch-heads/2490@{#140} Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925} (cherry picked from commit f7db687df527e95d3c94dd59597d99f6d1bb10d0)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M content/common/gpu/media/h264_decoder.cc View 3 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354993003/1
5 years, 3 months ago (2015-09-22 01:07:51 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 01:09:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698