Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1323143006: H264 Decoder: move cut off logic from Construct to ModifyRefPicList(). (Closed)

Created:
5 years, 3 months ago by hshi1
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

H264 Decoder: move cut off logic from Construct to ModifyRefPicList(). The ConstructRefPicListsP/B() functions are supposed to be slice agnostic. The cut off logic is based on per-slice num_ref_idx_lX_active_minus1 values in the slice header, and therefore it should belong to the ModifyRefPicList() function. BUG=479953 TEST=verify no corruption on xfnity, trybot, vda unit test Review URL: https://codereview.chromium.org/1318283007 Cr-Commit-Position: refs/heads/master@{#346947} (cherry picked from commit 5e19b061b92dd718401660d1899fd56bcd8637f9) TBR=posciak@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M content/common/gpu/media/h264_decoder.cc View 3 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323143006/1
5 years, 3 months ago (2015-09-02 21:39:39 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-02 21:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323143006/1
5 years, 3 months ago (2015-09-02 21:41:15 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 3 months ago (2015-09-02 21:41:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323143006/1
5 years, 3 months ago (2015-09-02 21:44:48 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 21:45:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698