Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: Source/platform/graphics/filters/FEConvolveMatrix.cpp

Issue 1354923003: Remove kernelUnitLength plumbing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More TEs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/filters/FEConvolveMatrix.cpp
diff --git a/Source/platform/graphics/filters/FEConvolveMatrix.cpp b/Source/platform/graphics/filters/FEConvolveMatrix.cpp
index a3859f418265decde2bbc679e01856afa8618ad5..ba5df1f46f830224b97dd2eb5b32e9838338ed94 100644
--- a/Source/platform/graphics/filters/FEConvolveMatrix.cpp
+++ b/Source/platform/graphics/filters/FEConvolveMatrix.cpp
@@ -34,14 +34,13 @@ namespace blink {
FEConvolveMatrix::FEConvolveMatrix(Filter* filter, const IntSize& kernelSize,
float divisor, float bias, const IntPoint& targetOffset, EdgeModeType edgeMode,
- const FloatPoint& kernelUnitLength, bool preserveAlpha, const Vector<float>& kernelMatrix)
+ bool preserveAlpha, const Vector<float>& kernelMatrix)
: FilterEffect(filter)
, m_kernelSize(kernelSize)
, m_divisor(divisor)
, m_bias(bias)
, m_targetOffset(targetOffset)
, m_edgeMode(edgeMode)
- , m_kernelUnitLength(kernelUnitLength)
, m_preserveAlpha(preserveAlpha)
, m_kernelMatrix(kernelMatrix)
{
@@ -51,9 +50,9 @@ FEConvolveMatrix::FEConvolveMatrix(Filter* filter, const IntSize& kernelSize,
PassRefPtrWillBeRawPtr<FEConvolveMatrix> FEConvolveMatrix::create(Filter* filter, const IntSize& kernelSize,
float divisor, float bias, const IntPoint& targetOffset, EdgeModeType edgeMode,
- const FloatPoint& kernelUnitLength, bool preserveAlpha, const Vector<float>& kernelMatrix)
+ bool preserveAlpha, const Vector<float>& kernelMatrix)
{
- return adoptRefWillBeNoop(new FEConvolveMatrix(filter, kernelSize, divisor, bias, targetOffset, edgeMode, kernelUnitLength,
+ return adoptRefWillBeNoop(new FEConvolveMatrix(filter, kernelSize, divisor, bias, targetOffset, edgeMode,
preserveAlpha, kernelMatrix));
}
@@ -141,21 +140,6 @@ bool FEConvolveMatrix::setEdgeMode(EdgeModeType edgeMode)
return true;
}
-FloatPoint FEConvolveMatrix::kernelUnitLength() const
-{
- return m_kernelUnitLength;
-}
-
-bool FEConvolveMatrix::setKernelUnitLength(const FloatPoint& kernelUnitLength)
-{
- ASSERT(kernelUnitLength.x() > 0);
- ASSERT(kernelUnitLength.y() > 0);
- if (m_kernelUnitLength == kernelUnitLength)
- return false;
- m_kernelUnitLength = kernelUnitLength;
- return true;
-}
-
bool FEConvolveMatrix::preserveAlpha() const
{
return m_preserveAlpha;
@@ -231,7 +215,6 @@ TextStream& FEConvolveMatrix::externalRepresentation(TextStream& ts, int indent)
<< "bias=\"" << m_bias << "\" "
<< "target=\"" << m_targetOffset << "\" "
<< "edgeMode=\"" << m_edgeMode << "\" "
- << "kernelUnitLength=\"" << m_kernelUnitLength << "\" "
<< "preserveAlpha=\"" << m_preserveAlpha << "\"]\n";
inputEffect(0)->externalRepresentation(ts, indent + 1);
return ts;
« no previous file with comments | « Source/platform/graphics/filters/FEConvolveMatrix.h ('k') | Source/platform/graphics/filters/FEDiffuseLighting.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698