Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: Source/core/svg/SVGFESpecularLightingElement.cpp

Issue 1354923003: Remove kernelUnitLength plumbing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More TEs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFESpecularLightingElement.h ('k') | Source/platform/graphics/filters/FEConvolveMatrix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFESpecularLightingElement.cpp
diff --git a/Source/core/svg/SVGFESpecularLightingElement.cpp b/Source/core/svg/SVGFESpecularLightingElement.cpp
index 9f3d5bd96402dc18a700aa2c74ea0a2bd1e3df08..9184b4300fb25a1e4f9df2c1c185d66cb1f8e3cd 100644
--- a/Source/core/svg/SVGFESpecularLightingElement.cpp
+++ b/Source/core/svg/SVGFESpecularLightingElement.cpp
@@ -73,11 +73,6 @@ bool SVGFESpecularLightingElement::setFilterEffectAttribute(FilterEffect* effect
return specularLighting->setSpecularConstant(m_specularConstant->currentValue()->value());
if (attrName == SVGNames::specularExponentAttr)
return specularLighting->setSpecularExponent(m_specularExponent->currentValue()->value());
- if (attrName == SVGNames::kernelUnitLengthAttr) {
- bool changedX = specularLighting->setKernelUnitLengthX(m_kernelUnitLength->firstNumber()->currentValue()->value());
- bool changedY = specularLighting->setKernelUnitLengthY(m_kernelUnitLength->secondNumber()->currentValue()->value());
- return changedX || changedY;
- }
LightSource* lightSource = const_cast<LightSource*>(specularLighting->lightSource());
SVGFELightElement* lightElement = SVGFELightElement::findLightElement(*this);
@@ -106,8 +101,7 @@ void SVGFESpecularLightingElement::svgAttributeChanged(const QualifiedName& attr
{
if (attrName == SVGNames::surfaceScaleAttr
|| attrName == SVGNames::specularConstantAttr
- || attrName == SVGNames::specularExponentAttr
- || attrName == SVGNames::kernelUnitLengthAttr) {
+ || attrName == SVGNames::specularExponentAttr) {
SVGElement::InvalidationGuard invalidationGuard(this);
primitiveAttributeChanged(attrName);
return;
@@ -151,7 +145,7 @@ PassRefPtrWillBeRawPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilt
RefPtr<LightSource> lightSource = lightNode->lightSource(filter);
RefPtrWillBeRawPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, m_surfaceScale->currentValue()->value(), m_specularConstant->currentValue()->value(),
- m_specularExponent->currentValue()->value(), kernelUnitLengthX()->currentValue()->value(), kernelUnitLengthY()->currentValue()->value(), lightSource.release());
+ m_specularExponent->currentValue()->value(), lightSource.release());
effect->inputEffects().append(input1);
return effect.release();
}
« no previous file with comments | « Source/core/svg/SVGFESpecularLightingElement.h ('k') | Source/platform/graphics/filters/FEConvolveMatrix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698