MediaRecorder: Adding BlobEvent and connecting it in MediaRecorderHandler

MediaRecorder: Adding BlobEvent and connecting it in MediaRecorderHandler

Note: MediaRecorder-basic-video.html is not reconnected yet 
due to missing infra (See http://crbug.com/532509 and
this is ref'd in TestExpectations [1])

BUG=262211
TEST= https://rawgit.com/Miguelao/demos/master/mediarecorder.html
(video of it at [2] -- sorry, just for @google accounts).


[1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/TestExpectations&sq=package:chromium&type=cs&q=TestExpectations%20MEdiaRecorder&l=409
[2] https://drive.google.com/open?id=0BwgFm5xOT0yCU3hScVh4WjIzZzQ

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202646

[mcasas, 2015-09-18 02:36:39]

Patchset #1 (id:1) has been deleted

[mcasas, 2015-09-18 02:55:00]

mcasas@chromium.org changed reviewers:
+ peter@chromium.org

[mcasas, 2015-09-18 02:55:00]

peter@ could you please have a fist pass? Thanks!

[Peter Beverloo, 2015-09-18 13:07:27]

Done! Mostly nits, plus a request to add a test for the BlobEvent interface.

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
recorder.onstop = recorderOnStopExpected;
The recorderOnStopExpected function is never defined? Did you run this test or
are it theoretical changes?

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/BlobEvent.h (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.h:20: virtual ~BlobEvent() {}
~BlobEvent() override {}

(The base class already defines it.)

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.h:23: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
canBubble, bool cancelable, Blob*);
nit: You could consider inlining the bodies of the static methods, since they
just defer to the constructors anyway. (This is quite common.)

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/BlobEvent.idl (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.idl:8: NoInterfaceObject
This is not a NoInterfaceObject per the specification:

http://www.w3.org/TR/mediastream-recording/#blob-event

(Good, because it shouldn't be for extensibility reasons :))

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.idl:9: ]
I see that Philip filed the following issue about the constructor for this
object:

https://github.com/w3c/mediacapture-record/issues/11

It seems to me that we should add the following annotation to the interface,
plus the associated constructor:

[
    Constructor(DOMString type, optional BlobEventInit eventInit)
]

Would you like that to do as part of this CL, or add a TODO and do this later?
It might be easy to do it in this CL, and it also makes it much easier for you
to write a sensible test for this interface (check the prototype, instantiate
with a created Blob, check that event.data == created blob).

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/MediaRecorder.cpp (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/MediaRecorder.cpp:245: void
MediaRecorder::createBlobEvent(const char* data, size_t length)
Out of interest, why do you find passing |data| and |length| to be more
convenient than passing a PassOwnPtr<BlobData>? I personally found that easier
to read than two calls to createBlobEvent(nullptr, 0);

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/MediaRecorder.cpp:247: // TODO(mcasas): Launch a
BlobEvent when that class is landed, but also see
https://github.com/w3c/mediacapture-record/issues/17.
This TODO is now redundant.

[mcasas, 2015-09-18 21:34:31]

Patchset #2 (id:40001) has been deleted

[mcasas, 2015-09-18 22:33:21]

Patchset #2 (id:60001) has been deleted

[mcasas, 2015-09-21 15:24:15]

Peter@ PTAL.

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
recorder.onstop = recorderOnStopExpected;
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> The recorderOnStopExpected function is never defined? Did you run this test or
> are it theoretical changes?

I didn't hit it in this test, but I surely did during the integration
phase, so I just thought it would be a good thing to catch that
here.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/BlobEvent.h (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.h:20: virtual ~BlobEvent() {}
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> ~BlobEvent() override {}
> 
> (The base class already defines it.)

Done.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.h:23: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
canBubble, bool cancelable, Blob*);
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> nit: You could consider inlining the bodies of the static methods, since they
> just defer to the constructors anyway. (This is quite common.)

Yeah, I'd love to, but in previous CLs I was instructed to
not inline them (see e.g. MediaRecorderErrorEvent in this 
folder) by esprehn@.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/BlobEvent.idl (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.idl:8: NoInterfaceObject
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> This is not a NoInterfaceObject per the specification:
> 
> http://www.w3.org/TR/mediastream-recording/#blob-event
> 
> (Good, because it shouldn't be for extensibility reasons :))

Done.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.idl:9: ]
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> I see that Philip filed the following issue about the constructor for this
> object:
> 
> https://github.com/w3c/mediacapture-record/issues/11
> 
> It seems to me that we should add the following annotation to the interface,
> plus the associated constructor:
> 
> [
>     Constructor(DOMString type, optional BlobEventInit eventInit)
> ]
> 
> Would you like that to do as part of this CL, or add a TODO and do this later?
> It might be easy to do it in this CL, and it also makes it much easier for you
> to write a sensible test for this interface (check the prototype, instantiate
> with a created Blob, check that event.data == created blob).

Done.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/MediaRecorder.cpp (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/MediaRecorder.cpp:245: void
MediaRecorder::createBlobEvent(const char* data, size_t length)
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> Out of interest, why do you find passing |data| and |length| to be more
> convenient than passing a PassOwnPtr<BlobData>? I personally found that easier
> to read than two calls to createBlobEvent(nullptr, 0);

Hmm this is just hanging around from the experiments
towards, well, making recording work :)
I changed it to passing a Blob*, so createBlobEvent()
doesn't need to Blob::create(BlobDataHandle::create())
in all cases, including those with null data.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/MediaRecorder.cpp:247: // TODO(mcasas): Launch a
BlobEvent when that class is landed, but also see
https://github.com/w3c/mediacapture-record/issues/17.
On 2015/09/18 13:07:26, Peter Beverloo wrote:
> This TODO is now redundant.

Rephrased.

[mcasas, 2015-09-21 22:25:08]

Patchset #2 (id:80001) has been deleted

[mcasas, 2015-09-21 22:28:41]

Patchset #2 (id:100001) has been deleted

[mcasas, 2015-09-22 13:45:19]

On 2015/09/21 15:24:15, mcasas wrote:
> Peter@ PTAL.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
> File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):
> 
>
https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
> LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
> recorder.onstop = recorderOnStopExpected;
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > The recorderOnStopExpected function is never defined? Did you run this test
or
> > are it theoretical changes?
> 
> I didn't hit it in this test, but I surely did during the integration
> phase, so I just thought it would be a good thing to catch that
> here.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> File Source/modules/mediarecorder/BlobEvent.h (right):
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/BlobEvent.h:20: virtual ~BlobEvent() {}
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > ~BlobEvent() override {}
> > 
> > (The base class already defines it.)
> 
> Done.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/BlobEvent.h:23: static
> PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
> canBubble, bool cancelable, Blob*);
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > nit: You could consider inlining the bodies of the static methods, since
they
> > just defer to the constructors anyway. (This is quite common.)
> 
> Yeah, I'd love to, but in previous CLs I was instructed to
> not inline them (see e.g. MediaRecorderErrorEvent in this 
> folder) by esprehn@.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> File Source/modules/mediarecorder/BlobEvent.idl (right):
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/BlobEvent.idl:8: NoInterfaceObject
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > This is not a NoInterfaceObject per the specification:
> > 
> > http://www.w3.org/TR/mediastream-recording/#blob-event
> > 
> > (Good, because it shouldn't be for extensibility reasons :))
> 
> Done.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/BlobEvent.idl:9: ]
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > I see that Philip filed the following issue about the constructor for this
> > object:
> > 
> > https://github.com/w3c/mediacapture-record/issues/11
> > 
> > It seems to me that we should add the following annotation to the interface,
> > plus the associated constructor:
> > 
> > [
> >     Constructor(DOMString type, optional BlobEventInit eventInit)
> > ]
> > 
> > Would you like that to do as part of this CL, or add a TODO and do this
later?
> > It might be easy to do it in this CL, and it also makes it much easier for
you
> > to write a sensible test for this interface (check the prototype,
instantiate
> > with a created Blob, check that event.data == created blob).
> 
> Done.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> File Source/modules/mediarecorder/MediaRecorder.cpp (right):
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/MediaRecorder.cpp:245: void
> MediaRecorder::createBlobEvent(const char* data, size_t length)
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > Out of interest, why do you find passing |data| and |length| to be more
> > convenient than passing a PassOwnPtr<BlobData>? I personally found that
easier
> > to read than two calls to createBlobEvent(nullptr, 0);
> 
> Hmm this is just hanging around from the experiments
> towards, well, making recording work :)
> I changed it to passing a Blob*, so createBlobEvent()
> doesn't need to Blob::create(BlobDataHandle::create())
> in all cases, including those with null data.
> 
>
https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
> Source/modules/mediarecorder/MediaRecorder.cpp:247: // TODO(mcasas): Launch a
> BlobEvent when that class is landed, but also see
> https://github.com/w3c/mediacapture-record/issues/17.
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > This TODO is now redundant.
> 
> Rephrased.

Peter ping.

[Peter Beverloo, 2015-09-22 14:03:43]

lgtm % comments (particularly the RuntimeEnabled= annotation). Thanks!

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
recorder.onstop = recorderOnStopExpected;
On 2015/09/21 15:24:15, mcasas wrote:
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > The recorderOnStopExpected function is never defined? Did you run this test
or
> > are it theoretical changes?
> 
> I didn't hit it in this test, but I surely did during the integration
> phase, so I just thought it would be a good thing to catch that
> here.

Yes, but you don't define |recorderOnStopExpected| anywhere - it's an undefined
variable. You should either define the function or remove this line from the
test.

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
File Source/modules/mediarecorder/BlobEvent.h (right):

https://codereview.chromium.org/1354863002/diff/20001/Source/modules/mediarec...
Source/modules/mediarecorder/BlobEvent.h:23: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
canBubble, bool cancelable, Blob*);
On 2015/09/21 15:24:15, mcasas wrote:
> On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > nit: You could consider inlining the bodies of the static methods, since
they
> > just defer to the constructors anyway. (This is quite common.)
> 
> Yeah, I'd love to, but in previous CLs I was instructed to
> not inline them (see e.g. MediaRecorderErrorEvent in this 
> folder) by esprehn@. 

OK. I disagree, but don't feel strongly either so let's just go with it.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.cpp (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.cpp:8: 
micro nit: no need for the blank line

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.h (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.h:24: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type);
You can remove this create() method and the associated constructor, they're
never called.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.h:26: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
canBubble, bool cancelable, Blob*);
As this is only being called by MediaRecorder, you may want to remove the
canBubble and cancelable arguments and force them to |false| in the constructor.
MediaRecorder has no reason to be able to change that behaviour.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.idl (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.idl:9: //
https://github.com/w3c/mediacapture-record/issues/11
It is, but the spec should be updated to properly define it. (Otherwise there is
no sense in defining BlobEventInit.)

What about the following TODO?

// The constructor is yet to be added to the specification, see:
// https://github.com/w3c/mediacapture-record/issues/11

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.idl:10: Constructor(DOMString type,
optional BlobEventInit eventInit)
RuntimeEnabled=MediaRecorder

[mcasas, 2015-09-22 16:18:04]

Patchset #3 (id:140001) has been deleted

[mcasas, 2015-09-22 16:18:09]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-09-22 16:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1354863002/#ps160001
(title: "peter@s comments")

[commit-bot: I haz the power, 2015-09-22 16:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354863002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354863002/160001

[mcasas, 2015-09-22 16:18:48]

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.cpp (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.cpp:8: 
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> micro nit: no need for the blank line

Actually, I also had no empty line originally :)

check-webkit-style failed
  Source/modules/mediarecorder/BlobEvent.cpp:7:  You should add a blank line
after implementation file's own header.  [build/include_order] [4]

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.h (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.h:24: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type);
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> You can remove this create() method and the associated constructor, they're
> never called.

Oops, you're right. Done.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.h:26: static
PassRefPtrWillBeRawPtr<BlobEvent> create(const AtomicString& type, bool
canBubble, bool cancelable, Blob*);
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> As this is only being called by MediaRecorder, you may want to remove the
> canBubble and cancelable arguments and force them to |false| in the
constructor.
> MediaRecorder has no reason to be able to change that behaviour.

Done.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
File Source/modules/mediarecorder/BlobEvent.idl (right):

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.idl:9: //
https://github.com/w3c/mediacapture-record/issues/11
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> It is, but the spec should be updated to properly define it. (Otherwise there
is
> no sense in defining BlobEventInit.)
> 
> What about the following TODO?
> 
> // The constructor is yet to be added to the specification, see:
> // https://github.com/w3c/mediacapture-record/issues/11

Done.

https://codereview.chromium.org/1354863002/diff/120001/Source/modules/mediare...
Source/modules/mediarecorder/BlobEvent.idl:10: Constructor(DOMString type,
optional BlobEventInit eventInit)
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> RuntimeEnabled=MediaRecorder

Done.

[Peter Beverloo, 2015-09-22 16:19:50]

Thank you for the updates.

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
recorder.onstop = recorderOnStopExpected;
On 2015/09/22 14:03:42, Peter Beverloo wrote:
> On 2015/09/21 15:24:15, mcasas wrote:
> > On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > > The recorderOnStopExpected function is never defined? Did you run this
test
> or
> > > are it theoretical changes?
> > 
> > I didn't hit it in this test, but I surely did during the integration
> > phase, so I just thought it would be a good thing to catch that
> > here.
> 
> Yes, but you don't define |recorderOnStopExpected| anywhere - it's an
undefined
> variable. You should either define the function or remove this line from the
> test.

You seem to have missed this?

[mcasas, 2015-09-22 16:20:33]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2015-09-22 16:35:12]

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
File LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html (right):

https://codereview.chromium.org/1354863002/diff/20001/LayoutTests/fast/mediar...
LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html:20:
recorder.onstop = recorderOnStopExpected;
On 2015/09/22 16:19:50, Peter Beverloo wrote:
> On 2015/09/22 14:03:42, Peter Beverloo wrote:
> > On 2015/09/21 15:24:15, mcasas wrote:
> > > On 2015/09/18 13:07:26, Peter Beverloo wrote:
> > > > The recorderOnStopExpected function is never defined? Did you run this
> test
> > or
> > > > are it theoretical changes?
> > > 
> > > I didn't hit it in this test, but I surely did during the integration
> > > phase, so I just thought it would be a good thing to catch that
> > > here.
> > 
> > Yes, but you don't define |recorderOnStopExpected| anywhere - it's an
> undefined
> > variable. You should either define the function or remove this line from the
> > test.
> 
> You seem to have missed this?

Ouch yes - sorry, it was a comment on the first PS and missed it
totally.

It was, indeed, a change lost in the branch-off-branch and cherry
picking, since I'm working on this test in parallel. The idea was to
have an "unexpected" onStop leading the test to fail, and an
"expected" onStop, being triggered after calling recorder.stop(),
which was expected and needed for the test to pass.

I should have bundled these changes in a separate CL, but thought
they'd be innocuous -since the test is disabled- and meaningful
-someone might read the code- enough to bundle them in.
them in

[mcasas, 2015-09-22 16:35:31]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-09-22 16:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1354863002/#ps180001
(title: "missed peter's comment")

[commit-bot: I haz the power, 2015-09-22 16:35:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354863002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354863002/180001

[commit-bot: I haz the power, 2015-09-22 18:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 18:23:10]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mcasas, 2015-09-22 18:59:47]

Patchset #5 (id:200001) has been deleted

[mcasas, 2015-09-22 19:00:17]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-09-22 19:00:17]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1354863002/#ps220001
(title: "Removed BlobEvent from global-interface-listing-expected.txt, and
rebase")

[commit-bot: I haz the power, 2015-09-22 19:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354863002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354863002/220001

[commit-bot: I haz the power, 2015-09-22 21:13:20]

Committed patchset #5 (id:220001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202646