Source/modules/mediarecorder/BlobEvent.idl - Issue 1354863002: MediaRecorder: Adding BlobEvent and connecting it in MediaRecorderHandler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediarecorder/BlobEvent.idl

Issue 1354863002: MediaRecorder: Adding BlobEvent and connecting it in MediaRecorderHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: MediaRecorder: BlobEvent Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/mediarecorder/BlobEvent.h ('K') | « Source/modules/mediarecorder/BlobEvent.cpp ('k') | Source/modules/mediarecorder/MediaRecorder.h » ('j') | Source/modules/mediarecorder/MediaRecorder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#blob-event

	6

	7 [

	8 NoInterfaceObject
	Peter Beverloo 2015/09/18 13:07:26 This is not a NoInterfaceObject per the specificat This is not a NoInterfaceObject per the specification: http://www.w3.org/TR/mediastream-recording/#blob-event (Good, because it shouldn't be for extensibility reasons :)) mcasas 2015/09/21 15:24:15 Done. Show quoted text On 2015/09/18 13:07:26, Peter Beverloo wrote: > This is not a NoInterfaceObject per the specification: > > http://www.w3.org/TR/mediastream-recording/#blob-event > > (Good, because it shouldn't be for extensibility reasons :)) Done.
	9 ]
	Peter Beverloo 2015/09/18 13:07:26 I see that Philip filed the following issue about I see that Philip filed the following issue about the constructor for this object: https://github.com/w3c/mediacapture-record/issues/11 It seems to me that we should add the following annotation to the interface, plus the associated constructor: [ Constructor(DOMString type, optional BlobEventInit eventInit) ] Would you like that to do as part of this CL, or add a TODO and do this later? It might be easy to do it in this CL, and it also makes it much easier for you to write a sensible test for this interface (check the prototype, instantiate with a created Blob, check that event.data == created blob). mcasas 2015/09/21 15:24:15 Done. Show quoted text On 2015/09/18 13:07:26, Peter Beverloo wrote: > I see that Philip filed the following issue about the constructor for this > object: > > https://github.com/w3c/mediacapture-record/issues/11 > > It seems to me that we should add the following annotation to the interface, > plus the associated constructor: > > [ > Constructor(DOMString type, optional BlobEventInit eventInit) > ] > > Would you like that to do as part of this CL, or add a TODO and do this later? > It might be easy to do it in this CL, and it also makes it much easier for you > to write a sensible test for this interface (check the prototype, instantiate > with a created Blob, check that event.data == created blob). Done.
	10 interface BlobEvent : Event {

	11 readonly attribute Blob data;

	12 };

OLD	NEW