Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1354773002: Avoid string construction overhead for lookup-only HpackEntry objects. (Closed)

Created:
5 years, 3 months ago by Bence
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid string construction overhead for lookup-only HpackEntry objects. Also slightly improve HpackEntry's debug logging. This CL lands server changes 103191204 by birenroy and 103647194 by bnc. BUG=488484 Committed: https://crrev.com/f8db20ed285c419a107fe94a07d1e946271ee7b5 Cr-Commit-Position: refs/heads/master@{#350206}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Implement non-trivial HpackEntry copy constructor and copy assignment operator. #

Patch Set 4 : Nit: return feels weird in a constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -18 lines) Patch
M net/spdy/hpack/hpack_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack/hpack_encoder_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_entry.h View 1 2 4 chunks +13 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_entry.cc View 1 2 3 1 chunk +37 lines, -6 lines 0 comments Download
M net/spdy/hpack/hpack_header_table_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 3 months ago (2015-09-22 14:16:35 UTC) #2
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-22 17:56:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354773002/60001
5 years, 3 months ago (2015-09-22 18:03:11 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-22 19:12:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:12:43 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f8db20ed285c419a107fe94a07d1e946271ee7b5
Cr-Commit-Position: refs/heads/master@{#350206}

Powered by Google App Engine
This is Rietveld 408576698