Avoid string construction overhead for lookup-only HpackEntry objects.

net/spdy/hpack/hpack_encoder_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack/hpack_encoder.h"
 
 #include <map>
 #include <string>
 
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 143 matching lines @@
   const HpackEntry* cookie_a_;
   const HpackEntry* cookie_c_;
 
   HpackOutputStream expected_;
 };
 
 TEST_F(HpackEncoderTest, SingleDynamicIndex) {
   ExpectIndex(IndexOf(key_2_));
 
   SpdyHeaderBlock headers;
-  headers[key_2_->name()] = key_2_->value();
+  headers[key_2_->name().as_string()] = key_2_->value().as_string();
   CompareWithExpectedEncoding(headers);
 }
 
 TEST_F(HpackEncoderTest, SingleStaticIndex) {
   ExpectIndex(IndexOf(static_));
 
   SpdyHeaderBlock headers;
-  headers[static_->name()] = static_->value();
+  headers[static_->name().as_string()] = static_->value().as_string();
   CompareWithExpectedEncoding(headers);
 }
 
 TEST_F(HpackEncoderTest, SingleStaticIndexTooLarge) {
   peer_.table()->SetMaxSize(1);  // Also evicts all fixtures.
   ExpectIndex(IndexOf(static_));
 
   SpdyHeaderBlock headers;
-  headers[static_->name()] = static_->value();
+  headers[static_->name().as_string()] = static_->value().as_string();
   CompareWithExpectedEncoding(headers);
 
   EXPECT_EQ(0u, peer_.table_peer().dynamic_entries()->size());
 }
 
 TEST_F(HpackEncoderTest, SingleLiteralWithIndexName) {
   ExpectIndexedLiteral(key_2_, "value3");
 
   SpdyHeaderBlock headers;
-  headers[key_2_->name()] = "value3";
+  headers[key_2_->name().as_string()] = "value3";
   CompareWithExpectedEncoding(headers);
 
   // A new entry was inserted and added to the reference set.
   HpackEntry* new_entry = &peer_.table_peer().dynamic_entries()->front();
   EXPECT_EQ(new_entry->name(), key_2_->name());
   EXPECT_EQ(new_entry->value(), "value3");
 }
 
 TEST_F(HpackEncoderTest, SingleLiteralWithLiteralName) {
   ExpectIndexedLiteral("key3", "value3");
@@ skipping 21 matching lines @@
   EXPECT_EQ(0u, peer_.table_peer().dynamic_entries()->size());
 }
 
 TEST_F(HpackEncoderTest, EmitThanEvict) {
   // |key_1_| is toggled and placed into the reference set,
   // and then immediately evicted by "key3".
   ExpectIndex(IndexOf(key_1_));
   ExpectIndexedLiteral("key3", "value3");
 
   SpdyHeaderBlock headers;
-  headers[key_1_->name()] = key_1_->value();
+  headers[key_1_->name().as_string()] = key_1_->value().as_string();
   headers["key3"] = "value3";
   CompareWithExpectedEncoding(headers);
 }
 
 TEST_F(HpackEncoderTest, CookieHeaderIsCrumbled) {
   ExpectIndex(IndexOf(cookie_a_));
   ExpectIndex(IndexOf(cookie_c_));
   ExpectIndexedLiteral(peer_.table()->GetByName("cookie"), "e=ff");
 
   SpdyHeaderBlock headers;
@@ skipping 212 matching lines @@
   expected_.AppendUint32(62);
   expected_.AppendPrefix(kStringLiteralIdentityEncoded);
   expected_.AppendUint32(3);
   expected_.AppendBytes("bar");
   CompareWithExpectedEncoding(headers);
 }
 
 }  // namespace
 
 }  // namespace net