|
|
Created:
6 years, 10 months ago by Marijn Kruisselbrink Modified:
6 years, 10 months ago Reviewers:
asargent_no_longer_on_chrome CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd unittest that tests behavior when downloading a crx fails.
BUG=338164
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248520
Patch Set 1 : #
Total comments: 1
Messages
Total messages: 20 (0 generated)
(the bug number is a crash that happened in this code path, which I fixed in https://codereview.chromium.org/139643005)
lgtm https://codereview.chromium.org/135473004/diff/30002/chrome/browser/extension... File chrome/browser/extensions/updater/extension_updater_unittest.cc (right): https://codereview.chromium.org/135473004/diff/30002/chrome/browser/extension... chrome/browser/extensions/updater/extension_updater_unittest.cc:173: &ExtensionDownloaderDelegate::GetExtensionExistingVersion)); ZOMG gtest
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on linux_rel for step(s) cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chromedriver_unittests, components_unittests, content_browsertests, content_unittests, crypto_unittests, google_apis_unittests, gpu_unittests, ipc_tests, jingle_unittests, media_unittests, nacl_integration, ppapi_unittests, printing_unittests, remoting_unittests, sandbox_linux_unittests, sql_unittests, sync_integration_tests, sync_unit_tests, telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on linux_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
CQ bit was unchecked on CL. Ignoring.
CQ bit was unchecked on CL. Ignoring.
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
Message was sent while issue was closed.
Change committed as 248520
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring. |