Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 135473004: Add unittest that tests behavior when downloading a crx fails. (Closed)

Created:
6 years, 10 months ago by Marijn Kruisselbrink
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add unittest that tests behavior when downloading a crx fails. BUG=338164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248520

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -15 lines) Patch
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 6 chunks +63 lines, -15 lines 1 comment Download

Messages

Total messages: 20 (0 generated)
Marijn Kruisselbrink
6 years, 10 months ago (2014-01-31 22:13:31 UTC) #1
Marijn Kruisselbrink
(the bug number is a crash that happened in this code path, which I fixed ...
6 years, 10 months ago (2014-01-31 22:14:46 UTC) #2
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/135473004/diff/30002/chrome/browser/extensions/updater/extension_updater_unittest.cc File chrome/browser/extensions/updater/extension_updater_unittest.cc (right): https://codereview.chromium.org/135473004/diff/30002/chrome/browser/extensions/updater/extension_updater_unittest.cc#newcode173 chrome/browser/extensions/updater/extension_updater_unittest.cc:173: &ExtensionDownloaderDelegate::GetExtensionExistingVersion)); ZOMG gtest
6 years, 10 months ago (2014-02-01 00:55:04 UTC) #3
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 10 months ago (2014-02-01 01:07:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
6 years, 10 months ago (2014-02-01 01:07:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 01:29:17 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chromedriver_unittests, components_unittests, ...
6 years, 10 months ago (2014-02-01 01:29:17 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 01:29:23 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 01:29:26 UTC) #9
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 10 months ago (2014-02-03 15:53:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
6 years, 10 months ago (2014-02-03 15:53:43 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 16:21:17 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222253
6 years, 10 months ago (2014-02-03 16:21:17 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:21:19 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:21:24 UTC) #15
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 10 months ago (2014-02-03 16:32:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/135473004/30002
6 years, 10 months ago (2014-02-03 16:32:53 UTC) #17
commit-bot: I haz the power
Change committed as 248520
6 years, 10 months ago (2014-02-03 17:50:32 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 17:50:36 UTC) #19
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 17:50:41 UTC) #20
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698