Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1354723004: [android] Change the recommended log tag format to "cr_foo" (Closed)

Created:
5 years, 3 months ago by dgn
Modified:
5 years, 3 months ago
CC:
Bons, chromium-reviews, kalyank, nodir, sadrul, simonb (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Change the recommended log tag format to "cr_foo" This is to ensure that log tags are not elided when retrieving logcat output from crash reports. The log function has been modified to make the transition easier and avoid specifying the prefix everywhere. This patch also moves some eliding testing from instrumentation tests to junit tests, and adds a test to ensure that the new tag format is not elided. BUG=533072 Committed: https://crrev.com/38736db9311bb4b03e6f555d71dc98b7fd341d37 Cr-Commit-Position: refs/heads/master@{#349733}

Patch Set 1 #

Patch Set 2 : Reject "cr." #

Patch Set 3 : Added tag normalization in the log functions #

Patch Set 4 : Fix presubmit test broken by another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -356 lines) Patch
M PRESUBMIT.py View 1 2 5 chunks +16 lines, -9 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 3 5 chunks +37 lines, -16 lines 0 comments Download
M base/android/java/src/org/chromium/base/Log.java View 1 2 12 chunks +45 lines, -18 lines 0 comments Download
M base/android/junit/src/org/chromium/base/LogTest.java View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 3 chunks +0 lines, -192 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 8 chunks +41 lines, -110 lines 0 comments Download
M docs/android_logging.md View 1 2 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
dgn
PTAL. I just sent an email to the internal team list for context.
5 years, 3 months ago (2015-09-17 20:46:07 UTC) #2
jochen (gone - plz use gerrit)
presubmit lgtm
5 years, 3 months ago (2015-09-18 08:34:03 UTC) #3
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-18 09:05:56 UTC) #4
dgn
PTAL: I made the log functions update the tag (this is happening only when we ...
5 years, 3 months ago (2015-09-18 12:08:08 UTC) #6
Bernhard Bauer
still lgtm
5 years, 3 months ago (2015-09-18 13:02:56 UTC) #7
rmcilroy
base/android lgtm.
5 years, 3 months ago (2015-09-18 13:31:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354723004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354723004/40001
5 years, 3 months ago (2015-09-18 15:51:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/101540)
5 years, 3 months ago (2015-09-18 16:02:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354723004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354723004/60001
5 years, 3 months ago (2015-09-18 16:18:56 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-18 19:20:57 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 19:22:03 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/38736db9311bb4b03e6f555d71dc98b7fd341d37
Cr-Commit-Position: refs/heads/master@{#349733}

Powered by Google App Engine
This is Rietveld 408576698