base/android/junit/src/org/chromium/base/LogTest.java - Issue 1354723004: [android] Change the recommended log tag format to "cr_foo"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/junit/src/org/chromium/base/LogTest.java

Issue 1354723004: [android] Change the recommended log tag format to "cr_foo" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix presubmit test broken by another CL Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/Log.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/junit/src/org/chromium/base/LogTest.java

diff --git a/base/android/junit/src/org/chromium/base/LogTest.java b/base/android/junit/src/org/chromium/base/LogTest.java

index 6f4e406304dba71761a08686b26f7500a84dd2aa..745ac8c7eac637a824251f34909545666f90c454 100644

--- a/base/android/junit/src/org/chromium/base/LogTest.java

+++ b/base/android/junit/src/org/chromium/base/LogTest.java

@@ -32,6 +32,14 @@ public void callOriginTest() {

logs.get(0).msg.matches("\\[LogTest.java:\\d+\\].*"));

}

+ @Test

+ public void normalizeTagTest() {

+ assertEquals("cr_foo", Log.normalizeTag("cr.foo"));

+ assertEquals("cr_foo", Log.normalizeTag("cr_foo"));

+ assertEquals("cr_foo", Log.normalizeTag("foo"));

+ assertEquals("cr_ab_foo", Log.normalizeTag("ab_foo"));

+ }

/** Tests that exceptions provided to the log functions are properly recognized and printed. */

@Test

public void exceptionLoggingTest() {