Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: content/content_shell.gypi

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verify_no_objc.sh as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content_shell.gypi
diff --git a/content/content_shell.gypi b/content/content_shell.gypi
index 9d634b1eb6e5b4e382e833ae31df9da02a2fff0b..f8d63cbfcc06cb3f85300946a6d10e55b37318e6 100644
--- a/content/content_shell.gypi
+++ b/content/content_shell.gypi
@@ -564,30 +564,6 @@
'--scm=1',
'--version=<(content_shell_version)'],
},
- {
- # This postbuid step is responsible for creating the following
- # helpers:
- #
- # Content Shell Helper EH.app and Content Shell Helper NP.app are
- # created from Content Shell Helper.app.
- #
- # The EH helper is marked for an executable heap. The NP helper
- # is marked for no PIE (ASLR).
- 'postbuild_name': 'Make More Helpers',
- 'action': [
- '../build/mac/make_more_helpers.sh',
- 'Frameworks',
- '<(content_shell_product_name)',
- ],
- },
- {
- # Make sure there isn't any Objective-C in the shell's
- # executable.
- 'postbuild_name': 'Verify No Objective-C',
- 'action': [
- '../build/mac/verify_no_objc.sh',
- ],
- },
],
}], # OS=="mac"
['OS=="android"', {
@@ -857,14 +833,6 @@
'--scm=0',
'--version=<(content_shell_version)'],
},
- {
- # Make sure there isn't any Objective-C in the helper app's
- # executable.
- 'postbuild_name': 'Verify No Objective-C',
- 'action': [
- '../build/mac/verify_no_objc.sh',
- ],
- },
],
'conditions': [
['component=="shared_library"', {

Powered by Google App Engine
This is Rietveld 408576698