Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1354613002: [heap] Cleanup: Align naming of parallel sweeping with parallel compaction. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup: Align naming of parallel sweeping with parallel compaction. Pure refactoring. R=hpayer@chromium.org BUG= Committed: https://crrev.com/8eec02b308852520bb1ad35cfa8066af0f0c5431 Cr-Commit-Position: refs/heads/master@{#30822}

Patch Set 1 #

Patch Set 2 : As discussed, renamed sweeper jobs to tasks #

Patch Set 3 : Fix initialization order in constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -70 lines) Patch
M src/heap/mark-compact.h View 1 2 chunks +19 lines, -19 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 14 chunks +28 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 4 chunks +19 lines, -23 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Lippautz
PTAL; As discussed, this is a pure refactoring CL that brings in line parallel sweeping ...
5 years, 3 months ago (2015-09-18 09:59:00 UTC) #2
Hannes Payer (out of office)
On 2015/09/18 09:59:00, Michael Lippautz wrote: > PTAL; As discussed, this is a pure refactoring ...
5 years, 3 months ago (2015-09-18 10:05:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354613002/20001
5 years, 3 months ago (2015-09-18 10:16:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9843) v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-18 10:18:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354613002/40001
5 years, 3 months ago (2015-09-18 10:23:02 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-18 10:49:16 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:49:28 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8eec02b308852520bb1ad35cfa8066af0f0c5431
Cr-Commit-Position: refs/heads/master@{#30822}

Powered by Google App Engine
This is Rietveld 408576698