Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: src/heap/mark-compact.h

Issue 1354613002: [heap] Cleanup: Align naming of parallel sweeping with parallel compaction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix initialization order in constructor Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index 6fc5dbba6206421feba3dab05b972d7331c771e8..6558eb2ddebba2b6349c64eb2fbf4f2c9ea40247 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -542,27 +542,8 @@ class MarkCompactCollector {
MarkingParity marking_parity_;
- // True if we are collecting slots to perform evacuation from evacuation
- // candidates.
- bool compacting_;
-
bool was_marked_incrementally_;
- // True if concurrent or parallel sweeping is currently in progress.
- bool sweeping_in_progress_;
-
- // True if parallel compaction is currently in progress.
- bool parallel_compaction_in_progress_;
-
- // Synchronize sweeper threads.
- base::Semaphore pending_sweeper_jobs_semaphore_;
-
- // Synchronize compaction tasks.
- base::Semaphore pending_compaction_tasks_semaphore_;
-
- // Number of active compaction tasks (including main thread).
- intptr_t concurrent_compaction_tasks_active_;
-
bool evacuation_;
SlotsBufferAllocator* slots_buffer_allocator_;
@@ -793,6 +774,25 @@ class MarkCompactCollector {
base::SmartPointer<FreeList> free_list_code_space_;
base::SmartPointer<FreeList> free_list_map_space_;
+ // True if we are collecting slots to perform evacuation from evacuation
+ // candidates.
+ bool compacting_;
+
+ // True if concurrent or parallel sweeping is currently in progress.
+ bool sweeping_in_progress_;
+
+ // True if parallel compaction is currently in progress.
+ bool compaction_in_progress_;
+
+ // Semaphore used to synchronize sweeper tasks.
+ base::Semaphore pending_sweeper_tasks_semaphore_;
+
+ // Semaphore used to synchronize compaction tasks.
+ base::Semaphore pending_compaction_tasks_semaphore_;
+
+ // Number of active compaction tasks (including main thread).
+ intptr_t concurrent_compaction_tasks_active_;
+
friend class Heap;
};
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698