Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1354523002: Revert of Add debug symbols to all generated .isolate. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, chromoting-reviews_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, peter+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, Matt Giuca, jdduke+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, tapted, mlamouri+watch-notifications_chromium.org, media-router+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, Aaron Boodman, danakj+watch_chromium.org, Ken Russell (switch to Gerrit), Dirk Pranke, Nico
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add debug symbols to all generated .isolate. (patchset #1 id:420001 of https://codereview.chromium.org/1245703002/ ) Reason for revert: Speculative, possibly caused "dyld: Library not loaded: @rpath/libchrome_main_dll.dylib" test failures in http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/11859 Original issue's description: > Add debug symbols to all generated .isolate. > > This will increase the amount of data being uploaded by a ~2x factor or so. > Debug symbols are usually larger than the executable itself on pretty much all > toolsets but generally have the advantage of being highly compressible. The > increase of data not a problem anymore with isolate-go. There will be a small > increase of latency but it should be bearable, especially by the gain of > enabling stack traces to work for isolated tests on Swarming. > > R=jam@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/8125ce3c695e6d8c02f3b51b16d49e17e7934bb4 > Cr-Commit-Position: refs/heads/master@{#349231} TBR=jam@chromium.org,kbr@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/29ea88c651e6bd8656713cfc2a8f88eff267518d Cr-Commit-Position: refs/heads/master@{#349342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -95 lines) Patch
M tools/isolate_driver.py View 4 chunks +38 lines, -95 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add debug symbols to all generated .isolate.
5 years, 3 months ago (2015-09-17 03:16:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354523002/1
5 years, 3 months ago (2015-09-17 03:16:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 03:16:59 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 03:17:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29ea88c651e6bd8656713cfc2a8f88eff267518d
Cr-Commit-Position: refs/heads/master@{#349342}

Powered by Google App Engine
This is Rietveld 408576698