|
|
Created:
5 years, 5 months ago by M-A Ruel Modified:
5 years, 3 months ago CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, chromoting-reviews_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, peter+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, Matt Giuca, jdduke+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, tapted, mlamouri+watch-notifications_chromium.org, media-router+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, Aaron Boodman, danakj+watch_chromium.org, Ken Russell (switch to Gerrit), Dirk Pranke, Nico Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_process Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd debug symbols to all generated .isolate.
This will increase the amount of data being uploaded by a ~2x factor or so.
Debug symbols are usually larger than the executable itself on pretty much all
toolsets but generally have the advantage of being highly compressible. The
increase of data not a problem anymore with isolate-go. There will be a small
increase of latency but it should be bearable, especially by the gain of
enabling stack traces to work for isolated tests on Swarming.
R=jam@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/8125ce3c695e6d8c02f3b51b16d49e17e7934bb4
Cr-Commit-Position: refs/heads/master@{#349231}
Patch Set 1 : . #
Messages
Total messages: 35 (26 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #2 (id:80001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #2 (id:140001) has been deleted
Patchset #1 (id:120001) has been deleted
Patchset #2 (id:180001) has been deleted
Patchset #1 (id:160001) has been deleted
Patchset #1 (id:200001) has been deleted
Patchset #3 (id:260001) has been deleted
Patchset #3 (id:280001) has been deleted
Patchset #2 (id:240001) has been deleted
Patchset #1 (id:220001) has been deleted
Patchset #1 (id:300001) has been deleted
Patchset #1 (id:320001) has been deleted
Patchset #1 (id:340001) has been deleted
Patchset #1 (id:360001) has been deleted
Patchset #1 (id:380001) has been deleted
Patchset #1 (id:400001) has been deleted
It works. It did increase the amount of data uploaded on Windows, from ~2Gb to ~4Gb but didn't increase the duration of 'isolate tests', for example http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_... took 1m10s which is totally reasonable. https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=7a1356f6... confirms chrome.dll.pdb and chrome.exe.pdb and friends are automatically added. The CL itself is ugly but I still wanted to do it so we would have a baseline that PDBs are pushed ASAP, so it can safely be enabled in GN right away and we can assume debug symbols should always be pushed. Hopefully this code will be deleted within the next year. (I'm also optimistic).
maruel@chromium.org changed reviewers: - dpranke@chromium.org, thakis@chromium.org
rubberstamp lgtm great!
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245703002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245703002/420001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245703002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245703002/420001
Message was sent while issue was closed.
Committed patchset #1 (id:420001)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8125ce3c695e6d8c02f3b51b16d49e17e7934bb4 Cr-Commit-Position: refs/heads/master@{#349231}
Message was sent while issue was closed.
kbr@chromium.org changed reviewers: + kbr@chromium.org
Message was sent while issue was closed.
Thanks for pushing this forward!
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:420001) has been created in https://codereview.chromium.org/1354523002/ by thakis@chromium.org. The reason for reverting is: Speculative, possibly caused "dyld: Library not loaded: @rpath/libchrome_main_dll.dylib" test failures in http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29.... |