google_apis/gcm/monitoring/fake_gcm_stats_recorder.h - Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/monitoring/fake_gcm_stats_recorder.h

Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/monitoring/fake_gcm_stats_recorder.h

diff --git a/google_apis/gcm/monitoring/fake_gcm_stats_recorder.h b/google_apis/gcm/monitoring/fake_gcm_stats_recorder.h

index ba8acfdf8bfa82727e5bedd681da47cf7332a68f..e0350f4aab84f37abebfa636016fbc0d4f8c32a7 100644

--- a/google_apis/gcm/monitoring/fake_gcm_stats_recorder.h

+++ b/google_apis/gcm/monitoring/fake_gcm_stats_recorder.h

@@ -18,7 +18,8 @@ class FakeGCMStatsRecorder : public GCMStatsRecorder {

void RecordCheckinInitiated(uint64 android_id) override;

void RecordCheckinDelayedDueToBackoff(int64 delay_msec) override;

void RecordCheckinSuccess() override;

- void RecordCheckinFailure(std::string status, bool will_retry) override;

+ void RecordCheckinFailure(const std::string& status,

+ bool will_retry) override;

void RecordConnectionInitiated(const std::string& host) override;

void RecordConnectionDelayedDueToBackoff(int64 delay_msec) override;

void RecordConnectionSuccess() override;

« no previous file with comments | « google_apis/gaia/oauth2_token_service_test_util.cc ('k') | google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc » ('j') | no next file with comments »