Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc

Issue 1354373002: Cleanup: Pass std::string as const reference from google_apis/ and components/gcm_driver/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against ToT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc
diff --git a/google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc b/google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc
index f2934d45416a33fcccd2bffa5090eae981f2b00e..e61570ac80626f53bfef278164549e75c388f4c1 100644
--- a/google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc
+++ b/google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc
@@ -21,9 +21,8 @@ void FakeGCMStatsRecorder::RecordCheckinDelayedDueToBackoff(int64 delay_msec) {
void FakeGCMStatsRecorder::RecordCheckinSuccess() {
}
-void FakeGCMStatsRecorder::RecordCheckinFailure(std::string status,
- bool will_retry) {
-}
+void FakeGCMStatsRecorder::RecordCheckinFailure(const std::string& status,
+ bool will_retry) {}
void FakeGCMStatsRecorder::RecordConnectionInitiated(const std::string& host) {
}
« no previous file with comments | « google_apis/gcm/monitoring/fake_gcm_stats_recorder.h ('k') | google_apis/gcm/monitoring/gcm_stats_recorder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698