content/browser/shared_worker/shared_worker_service_impl_unittest.cc - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_service_impl_unittest.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/shared_worker/shared_worker_service_impl_unittest.cc

diff --git a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc

index 70dde1d3ec42f28fb8c98b580b9c30c5a6288fd5..5c3906853fb1a7bb3062c56b16f9c8ec86e749d3 100644

--- a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc

+++ b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc

@@ -284,7 +284,7 @@ class MockSharedWorkerConnector {

EXPECT_TRUE(renderer_host_->OnMessageReceived(

new MessagePortHostMsg_QueueMessages(remote_port_id_)));

}

- void SendPostMessage(std::string data) {

+ void SendPostMessage(const std::string& data) {

const std::vector<TransferredMessagePort> empty_ports;

EXPECT_TRUE(

renderer_host_->OnMessageReceived(new MessagePortHostMsg_PostMessage(

« no previous file with comments | « content/browser/session_history_browsertest.cc ('k') | content/browser/speech/speech_recognition_browsertest.cc » ('j') | no next file with comments »