Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: content/browser/shared_worker/shared_worker_service_impl_unittest.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <set> 6 #include <set>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/atomic_sequence_num.h" 9 #include "base/atomic_sequence_num.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 url, 277 url,
278 name, 278 name,
279 document_id, 279 document_id,
280 render_frame_route_id, 280 render_frame_route_id,
281 &route_id_); 281 &route_id_);
282 } 282 }
283 void SendQueueMessages() { 283 void SendQueueMessages() {
284 EXPECT_TRUE(renderer_host_->OnMessageReceived( 284 EXPECT_TRUE(renderer_host_->OnMessageReceived(
285 new MessagePortHostMsg_QueueMessages(remote_port_id_))); 285 new MessagePortHostMsg_QueueMessages(remote_port_id_)));
286 } 286 }
287 void SendPostMessage(std::string data) { 287 void SendPostMessage(const std::string& data) {
288 const std::vector<TransferredMessagePort> empty_ports; 288 const std::vector<TransferredMessagePort> empty_ports;
289 EXPECT_TRUE( 289 EXPECT_TRUE(
290 renderer_host_->OnMessageReceived(new MessagePortHostMsg_PostMessage( 290 renderer_host_->OnMessageReceived(new MessagePortHostMsg_PostMessage(
291 local_port_id_, 291 local_port_id_,
292 MessagePortMessage(base::ASCIIToUTF16(data)), empty_ports))); 292 MessagePortMessage(base::ASCIIToUTF16(data)), empty_ports)));
293 } 293 }
294 void SendConnect() { 294 void SendConnect() {
295 EXPECT_TRUE( 295 EXPECT_TRUE(
296 renderer_host_->OnMessageReceived(new ViewHostMsg_ForwardToWorker( 296 renderer_host_->OnMessageReceived(new ViewHostMsg_ForwardToWorker(
297 WorkerMsg_Connect(route_id_, remote_port_id_, MSG_ROUTING_NONE)))); 297 WorkerMsg_Connect(route_id_, remote_port_id_, MSG_ROUTING_NONE))));
(...skipping 612 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 kDocumentIDs[2], 910 kDocumentIDs[2],
911 kRenderFrameRouteIDs[2]); 911 kRenderFrameRouteIDs[2]);
912 EXPECT_NE(MSG_ROUTING_NONE, connector2->route_id()); 912 EXPECT_NE(MSG_ROUTING_NONE, connector2->route_id());
913 EXPECT_EQ(0U, renderer_host2->QueuedMessageCount()); 913 EXPECT_EQ(0U, renderer_host2->QueuedMessageCount());
914 RunAllPendingInMessageLoop(); 914 RunAllPendingInMessageLoop();
915 EXPECT_EQ(1U, renderer_host2->QueuedMessageCount()); 915 EXPECT_EQ(1U, renderer_host2->QueuedMessageCount());
916 CheckViewMsgWorkerCreated(renderer_host2.get(), connector2.get()); 916 CheckViewMsgWorkerCreated(renderer_host2.get(), connector2.get());
917 } 917 }
918 918
919 } // namespace content 919 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/session_history_browsertest.cc ('k') | content/browser/speech/speech_recognition_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698