content/browser/renderer_host/p2p/socket_host_test_utils.h - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_test_utils.h

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc ('k') | content/browser/renderer_host/p2p/socket_host_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_test_utils.h

diff --git a/content/browser/renderer_host/p2p/socket_host_test_utils.h b/content/browser/renderer_host/p2p/socket_host_test_utils.h

index 76358d2fa4b981842714703cef5a87f172c02ec5..17172e6f79c42491dc47f33aee72abda769453cd 100644

--- a/content/browser/renderer_host/p2p/socket_host_test_utils.h

+++ b/content/browser/renderer_host/p2p/socket_host_test_utils.h

@@ -95,7 +95,7 @@ void CreateStunRequest(std::vector<char>* packet);

void CreateStunResponse(std::vector<char>* packet);

void CreateStunError(std::vector<char>* packet);

-net::IPEndPoint ParseAddress(const std::string ip_str, uint16 port);

+net::IPEndPoint ParseAddress(const std::string& ip_str, uint16 port);

MATCHER_P(MatchMessage, type, "") {

return arg->type() == type;