content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc - Issue 1354363002: Cleanup: Pass std::string as const reference from content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

Issue 1354363002: Cleanup: Pass std::string as const reference from content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/file_system_dir_url_request_job_unittest.cc ('k') | content/browser/renderer_host/p2p/socket_host_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc b/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

index 43017e9d482cfa64e4e67011605159a3e222a281..bba0c76e3af768cd2c2d4e68078c5f3cbbe97e04 100644

--- a/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc

@@ -476,7 +476,7 @@ TEST(IndexedDBLevelDBCodingTest, CompareEncodedStringsWithLength) {

}

-static std::string WrappedEncodeBinary(std::string value) {

+static std::string WrappedEncodeBinary(const std::string& value) {

std::string buffer;

EncodeBinary(value, &buffer);

return buffer;