Issue 1354353003: Cleanup: Pass std::string as const reference from ios/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1354353003: Cleanup: Pass std::string as const reference from ios/ (Closed)

Created:
5 years, 3 months ago by ki.stfu

Modified:
5 years, 3 months ago

Reviewers:
droger, rohitrao (ping after 24h)

CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Pass std::string as const reference from ios/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=droger@chromium.org,rohitrao@chromium.org Committed: https://crrev.com/7bc15415b97bcbf4a6115c7cbe870acb4e45b8fb Cr-Commit-Position: refs/heads/master@{#349910}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	ios/chrome/common/string_util.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ios/chrome/common/string_util.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ios/crnet/crnet_environment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/crnet/crnet_environment.mm	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	ios/web/navigation/crw_session_controller_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354353003/1

5 years, 3 months ago (2015-09-21 07:15:20 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 07:24:53 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7bc15415b97bcbf4a6115c7cbe870acb4e45b8fb
Cr-Commit-Position: refs/heads/master@{#349910}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages