ios/chrome/common/string_util.mm - Issue 1354353003: Cleanup: Pass std::string as const reference from ios/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/common/string_util.mm

Issue 1354353003: Cleanup: Pass std::string as const reference from ios/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/common/string_util.mm

diff --git a/ios/chrome/common/string_util.mm b/ios/chrome/common/string_util.mm

index d8fca0e71a6266a9389f853dc85c7f97beb9509e..395f66035276d4a244542b05aaa3a9063bc4469f 100644

--- a/ios/chrome/common/string_util.mm

+++ b/ios/chrome/common/string_util.mm

@@ -116,7 +116,8 @@ NSString* CleanNSStringForDisplay(NSString* dirty, BOOL removeGraphicChars) {

return cleanString;

}

-std::string CleanStringForDisplay(std::string dirty, BOOL removeGraphicChars) {

+std::string CleanStringForDisplay(const std::string& dirty,

+ BOOL removeGraphicChars) {

return base::SysNSStringToUTF8(CleanNSStringForDisplay(

base::SysUTF8ToNSString(dirty), removeGraphicChars));

}

« no previous file with comments | « ios/chrome/common/string_util.h ('k') | ios/crnet/crnet_environment.h » ('j') | no next file with comments »