Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: service/memcache/memcache.go

Issue 1354333002: Fix memcache.Interface.Get to return a memcache.Item (Closed) Base URL: https://github.com/luci/gae.git@fix_meta_serialize
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/memcache/interface.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/memcache/memcache.go
diff --git a/service/memcache/memcache.go b/service/memcache/memcache.go
index a814f705b0c79c68b57afaefc331d0970ffba419..8725fe526099c07857a087cb1c50847d96742ed0 100644
--- a/service/memcache/memcache.go
+++ b/service/memcache/memcache.go
@@ -21,8 +21,10 @@ func (m *memcacheImpl) Set(item Item) error {
return errors.SingleError(m.SetMulti([]Item{item}))
}
-func (m *memcacheImpl) Get(item Item) error {
- return errors.SingleError(m.GetMulti([]Item{item}))
+func (m *memcacheImpl) Get(key string) (Item, error) {
+ ret := m.NewItem(key)
+ err := errors.SingleError(m.GetMulti([]Item{ret}))
nodir 2015/09/19 08:14:30 what about accepting ...Item in GetMulti?
+ return ret, err
}
func (m *memcacheImpl) Delete(key string) error {
« no previous file with comments | « service/memcache/interface.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698