Fix memcache.Interface.Get to return a memcache.Item

service/memcache/memcache.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memcache
 
 import (
         "github.com/luci/luci-go/common/errors"
         "golang.org/x/net/context"
 )
 
 type memcacheImpl struct{ RawInterface }
 
 var _ Interface = (*memcacheImpl)(nil)
 
 func (m *memcacheImpl) Add(item Item) error {
         return errors.SingleError(m.AddMulti([]Item{item}))
 }
 
 func (m *memcacheImpl) Set(item Item) error {
         return errors.SingleError(m.SetMulti([]Item{item}))
 }
 
-func (m *memcacheImpl) Get(item Item) error {
-        return errors.SingleError(m.GetMulti([]Item{item}))
+func (m *memcacheImpl) Get(key string) (Item, error) {
+        ret := m.NewItem(key)
+        err := errors.SingleError(m.GetMulti([]Item{ret}))

[nodir, 2015/09/19 08:14:30]

what about accepting ...Item in GetMulti?

+        return ret, err
 }
 
 func (m *memcacheImpl) Delete(key string) error {
         return errors.SingleError(m.DeleteMulti([]string{key}))
 }
 
 func (m *memcacheImpl) CompareAndSwap(item Item) error {
         return errors.SingleError(m.CompareAndSwapMulti([]Item{item}))
 }
 
@@ skipping 83 matching lines @@
 func (m *memcacheImpl) IncrementExisting(key string, delta int64) (newValue uint64, err error) {
         return m.RawInterface.Increment(key, delta, nil)
 }
 
 func (m *memcacheImpl) Raw() RawInterface { return m.RawInterface }
 
 // Get gets the current memcache implementation from the context.
 func Get(c context.Context) Interface {
         return &memcacheImpl{GetRaw(c)}
 }